OEL-477: Create User profile card pattern, and field group custom form… #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Maxfire
suggested changes
Dec 3, 2021
| ]; | ||
|
|
||
| // Number of items in the first columns. | ||
| $first_column_elements = array_slice($children, 0, ceil(count($children) / 2)); |
There was a problem hiding this comment.
I think ceil is waiting for a float not an int
There was a problem hiding this comment.
In fact ceil can receive both int and floats, but in this case ceil is rounding up for then we have un-even elements.
|
|
||
| // Append RDF term mappings on displayed taxonomy links. | ||
| foreach (Element::children($build) as $field_name) { | ||
| $field = &$build[$field_name]; |
There was a problem hiding this comment.
If it's not returning anything, is this being used?
Maxfire
suggested changes
Dec 3, 2021
| /** | ||
| * {@inheritdoc} | ||
| */ | ||
| public function preRender(&$element, $rendering_object): void { |
There was a problem hiding this comment.
We have an issue with this according to the complexity, please have a look at https://drone.fpfis.eu/openeuropa/oe_whitelabel/483/20
| 'first_column' => '', | ||
| 'second_column' => '', | ||
| 'hide_table_if_empty' => FALSE, | ||
| ] + parent::defaultSettings($context); |
There was a problem hiding this comment.
The parent doesn't need a variable, do we need it here? just a question.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Override the card pattern for the user profile.
Create a custom Field Formatter for field group to print fields evenly in two columns