Add new fields and sections to the Program detail page #2557
Conversation
|
Hi @jbpenrath, can you give me some feedback on this or assign someone to help me review this and improve it? |
|
There are a couple of tasks not yet complete or dependent on other NAU teams PR, like the currency type, that should be a setting and not an hardcoded value. |
src/frontend/scss/components/templates/courses/cms/_program_detail.scss
Outdated
Show resolved
Hide resolved
src/frontend/scss/components/templates/courses/cms/_program_detail.scss
Outdated
Show resolved
Hide resolved
So your idea is to aggregate this information via courses without creating new manual fields. Do you think it would make sense to be able to manually override? I'm just trying to cover all the bases, due to the different typologies of programs we can have. |
It depends to your need. Concerning Editor UX and data consistency, It looks great to aggregate those data from related courses but if you know that those information will need to be overridden, I think your current implementation fullfil the need, is simpler so that's the best. |
| checkmark-list-decoration: url('../../richie/images/components/checkmark.svg'), | ||
| checkmark-list-decoration-color: r-color('indianred3'), |
There was a problem hiding this comment.
You should add an entry in the UPGRADE.md document to mention that if someone has override the program-detail map it must also declare those 2 new properties.
src/frontend/scss/components/templates/courses/cms/_program_detail.scss
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Be careful before merging that you don't need to regenerate this migration. e.g: If @Tiago-Salles merge its PR before you
https://github.com/openfun/richie/pull/2549/files
There was a problem hiding this comment.
I talked to @Tiago-Salles about this. I'll do a commit to correct everything.
src/richie/apps/courses/templates/courses/cms/program_detail.html
Outdated
Show resolved
Hide resolved
sandroscosta
force-pushed
the
sandroscosta/programs-page
branch
from
f5529b8 to
3d997c8
Compare
Add effort, duration, price, team, objectives and other optional fields.
sandroscosta
force-pushed
the
sandroscosta/programs-page
branch
from
3d997c8 to
4895556
Compare
Add effort, duration, price, team, objectives and other optional fields.
Purpose
As described in #2556, this PR adds new fields to the programs page and information disposition, much closer to the course detail template.
This allows for a better grasp on all the information related to the program.