Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[emotiva] Fix missing data in source channels #17365

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[emotiva] Fix missing data in source channels #17365

wants to merge 1 commit into from
+59 −79

Conversation

espenaf
Copy link
Contributor

@espenaf espenaf commented Sep 3, 2024

Fixes #17363

Can be backported to 4.2.x

@lsiepel lsiepel added the bug An unexpected problem or unintended behavior of an add-on label Sep 3, 2024
@lsiepel lsiepel changed the title [emotiva] Fixes issue with missing data in source channels [emotiva] Fix missing data in source channels Sep 3, 2024
@lsiepel lsiepel added rebuild Triggers Jenkins PR build and removed rebuild Triggers Jenkins PR build labels Sep 6, 2024
lsiepel
lsiepel requested changes Sep 6, 2024
View reviewed changes
Copy link
Contributor

@lsiepel lsiepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, left two minor comments.
Fine to merge for 4.3.0, for backporting, it would be nice to also have a user confirmed test to minimalise the risks for regression.

...ing.emotiva/src/main/java/org/openhab/binding/emotiva/internal/EmotivaUdpSendingService.java Show resolved Hide resolved
...ing.emotiva/src/main/java/org/openhab/binding/emotiva/internal/EmotivaUdpSendingService.java Outdated Show resolved Hide resolved
@espenaf
Copy link
Contributor Author

espenaf commented Sep 10, 2024

Thanks, left two minor comments. Fine to merge for 4.3.0, for backporting, it would be nice to also have a user confirmed test to minimalise the risks for regression.

Fixed the minor things. Where you thinking of an unit test or an actual user test?

@lsiepel
Copy link
Contributor

lsiepel commented Sep 10, 2024

Thanks, left two minor comments. Fine to merge for 4.3.0, for backporting, it would be nice to also have a user confirmed test to minimalise the risks for regression.

Fixed the minor things. Where you thinking of an unit test or an actual user test?

Depends on the extend of the unit tests. Add tests if you can and will see,

@lsiepel
Copy link
Contributor

lsiepel commented Sep 18, 2024 •
edited
Loading

@espenaf do you plan to add unit tests to this PR?

@espenaf
Copy link
Contributor Author

espenaf commented Sep 19, 2024

@espenaf do you plan to add unit tests to this PR?

I have started looking into it, but discovered I need to refactor a few things to be able to write some proper tests for this. Hopefully I will get it done over the weekend, but it could also be a separate PR to not cram to many changes into this fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lsiepel lsiepel lsiepel requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
bug An unexpected problem or unintended behavior of an add-on
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[emotiva] Source channels are not listing items recevied from device
2 participants
@espenaf @lsiepel