[samsungtv] Add artOrientatation channel

[NickWaterton]

Added new channel artOrientation for Frame TV's to report TV orientation (Landscape/Portrait), and allow triggering of the auto-rotation mount.

Added ability to disable Smartthings subscriptions, which enables polling of the Smartthings channels, for faster updating.

Signed-off-by: Nick Waterton [email protected]

org.openhab.binding.samsungtv-4.3.0-SNAPSHOT.jar
org.openhab.binding.samsungtv-4.3.0-SNAPSHOT.kar

[openhab-bot]

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/samsung-tv-binding-beta/130551/1

[jlaur]

@NickWaterton - thanks for the fix and enhancement. I'm wondering if we should backport the fix for NullPointerException to 4.2.x? If you agree, perhaps you could extract this part to a separate PR for being merged in a separate commit that we can then cherry-pick. This will also result in cleaner release notes with one bugfix and one enhancement.

[NickWaterton]

@NickWaterton - thanks for the fix and enhancement. I'm wondering if we should backport the fix for NullPointerException to 4.2.x? If you agree, perhaps you could extract this part to a separate PR for being merged in a separate commit that we can then cherry-pick. This will also result in cleaner release notes with one bugfix and one enhancement.

I'm not sure that it's worth all the extra work. It's a very specific set of circumstances that caused the NPE, and it's a rare combination.

I'm not even sure I know how to go about doing this.

[lsiepel]

Thanks for these improvements, left some comments to look at.

[lsiepel]

@NickWaterton could you update your branch to current main? I would have expected either some conflicts or some lines not to be included as they are aready added by the other patch.

[lsiepel]

Thanks, LGTM