Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[modbus] Discard data if transformation failed #17457

Merged
merged 1 commit into from
Sep 26, 2024
Merged

[modbus] Discard data if transformation failed #17457

merged 1 commit into from
Sep 26, 2024

Conversation

jimtng
Copy link
Contributor

@jimtng jimtng commented Sep 22, 2024

Resolve #16847

@jimtng jimtng mentioned this pull request Sep 22, 2024
Closed
@jimtng
Copy link
Contributor Author

jimtng commented Sep 22, 2024

If someone can test this, you can use this jar (renamed to .txt)

org.openhab.binding.modbus-4.3.0-SNAPSHOT.jar.txt

ssalonen
ssalonen approved these changes Sep 22, 2024
View reviewed changes
Copy link
Contributor

@ssalonen ssalonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@lsiepel lsiepel added enhancement An enhancement or new feature for an existing add-on additional testing preferred The change works for the pull request author. A test from someone else is preferred though. and removed additional testing preferred The change works for the pull request author. A test from someone else is preferred though. labels Sep 22, 2024
lsiepel
lsiepel approved these changes Sep 26, 2024
View reviewed changes
Copy link
Contributor

@lsiepel lsiepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@lsiepel lsiepel merged commit d44d84e into openhab:main Sep 26, 2024
5 checks passed
@lsiepel lsiepel added this to the 4.3 milestone Sep 26, 2024
@jimtng jimtng deleted the modbus-failed-transform branch September 27, 2024 05:01
joni1993 pushed a commit to joni1993/openhab-addons that referenced this pull request Oct 15, 2024
@jimtng @joni1993
[modbus] Discard data if transformation failed (openhab#17457)
787857a 
Signed-off-by: Jimmy Tanagra <[email protected]>
matchews pushed a commit to matchews/openhab-addons that referenced this pull request Oct 18, 2024
@jimtng @matchews
[modbus] Discard data if transformation failed (openhab#17457)
6d3482e 
Signed-off-by: Jimmy Tanagra <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lsiepel lsiepel lsiepel approved these changes

@ssalonen ssalonen ssalonen approved these changes

Assignees
No one assigned
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Milestone
4.3
3 participants
@jimtng @ssalonen @lsiepel