-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8343785: (fs) Remove syscalls that set file times with microsecond precision #21989
base: master
Are you sure you want to change the base?
Conversation
👋 Welcome back bpb! A progress list of the required criteria for merging this PR into |
❗ This change is not yet ready to be integrated. |
@TheRealMDoerr , @RealCLanger If this will eventually be integrated, it would be good if there were some testing on AIX before then. I don't think I've touched any AIX specific code, but one can't be too careful. Thanks. |
Webrevs
|
lutimes(path, accessValue, modValue); | ||
else | ||
futimens(fd, accessValue, modValue); | ||
UnixFileAttributes attrs = UnixFileAttributes.get(path, followLinks); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should use openForAttributeAccess if possible. If lastModifiedTime or lastAccessTime is not provided then it ensures that this method will only access one file to avoid racing with concurrent changes on the file system.
int commonattr = UnixConstants.ATTR_CMN_CRTIME; | ||
try { | ||
setattrlist(path, commonattr, 0L, 0L, createValue, | ||
followLinks ? 0 : UnixConstants.FSOPT_NOFOLLOW); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
followLinks ? 0 : UnixConstants.FSOPT_NOFOLLOW); | |
followLinks ? 0 : UnixConstants.FSOPT_NOFOLLOW); |
The included test has passed on linuxppc64le, but is disabled for AIX. At least the build has worked on AIX. We should try other tests. |
I guess we should add
Good. Thanks for checking.
Yes. |
Remove the syscalls
utimes
,futimes
, andlutimes
that set the file access and modification times using microsecond precision.Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/21989/head:pull/21989
$ git checkout pull/21989
Update a local copy of the PR:
$ git checkout pull/21989
$ git pull https://git.openjdk.org/jdk.git pull/21989/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 21989
View PR using the GUI difftool:
$ git pr show -t 21989
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/21989.diff
Using Webrev
Link to Webrev Comment