Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8352284: EXTRA_CFLAGS incorrectly applied to BUILD_LIBJVM src/hotspot C++ source files #24115

Closed
wants to merge 8 commits into from
Closed

8352284: EXTRA_CFLAGS incorrectly applied to BUILD_LIBJVM src/hotspot C++ source files #24115

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
cffbd3d
8352284: EXTRA_CFLAGS incorrectly applied to BUILD_LIBJVM src/hotspot…
cnqpzhang Mar 19, 2025
2b327a1
precompiled.hpp.gch should be compiled with EXTRA_CXXFLAGS
cnqpzhang Mar 19, 2025
cf61e94
STATIC_LIB_CFLAGS in Flags.gmk should be updated to -DSTATIC_BUILD=1 too
cnqpzhang Mar 19, 2025
20af4f7
Revert the changes of adding new params to SetupNativeCompilation
cnqpzhang Mar 20, 2025
6ee8297
Added comments to describe why EXTRA_CFLAGS is excluded from JVM_CFLAGS
cnqpzhang Mar 22, 2025
aa242dd
Fixed a typo
cnqpzhang Mar 22, 2025
5440ddc
Remove the comments wrt not appending EXTRA_CFLAGS to JVM_CFLAGS
cnqpzhang Mar 31, 2025
46c4392
Revertd the STATIC_LIB_CFLAGS fix as it is coverted by JDK-8353272
cnqpzhang Mar 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion make/hotspot/lib/JvmFlags.gmk
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,6 @@ JVM_CFLAGS += \
$(JVM_CFLAGS_TARGET_DEFINES) \
$(JVM_CFLAGS_FEATURES) \
$(JVM_CFLAGS_INCLUDES) \
$(EXTRA_CFLAGS) \
#

ifneq ($(HOTSPOT_OVERRIDE_LIBPATH), )
Expand Down