-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8339728: [Accessibility,Windows,JAWS] Bug in the getKeyChar method of the AccessBridge class #3001
Conversation
👋 Welcome back vieiro! A progress list of the required criteria for merging this PR into |
@vieiro This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 5 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@jerboaa) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
This backport pull request has now been updated with issue from the original commit. |
|
||
public class TestJMenuItemShortcutAccessibility { | ||
public static void main(String[] args) throws Exception { | ||
String INSTRUCTIONS = "" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one was a multiline String constant in JDK17 and above.
@fthevenet Could you please help test/review this patch. Thank you! |
Hmm... I can't seem to get JAWS to work with swing applications at all on my machine: it doesn't read anything from inside the JFrame (only the window title). This is I assume a configuration issue on my end, and has likely nothing to do with this change, as I've experienced the same with 11.0.26 and 23.0.2, but it means I unfortunately won't be able to test this until I get this working. |
OK. Thanks! |
Okay so today I learned that the accessibility bridge isn't enabled by default, and that you have to turn it on explicitly using I'm tempted to say that adding a short mention to turning on the accessibility bridge in the comments that describe how to run the test would go a long way toward saving some time to people who, like me, aren't familiar with screen readers, but I'm not sure that this is something that belong into a backport. WDYT @jerboaa ? [1] https://docs.oracle.com/en/java/javase/11/access/enabling-and-testing-java-access-bridge.html |
Thanks for the review, @fthevenet ! Maybe updating the doc/testing.md is a good idea too? |
Yes, not something to introduce in this backport. Feel free to propose this simple change in https://github.com/openjdk/jdk, @fthevenet |
It could be. Propose this for JDK head first, though. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clean but for an update in copyright header and for a multi-line string (that has been replaced) in
AccessBridge.java
.
Confirmed. Patch looks fine to me.
|
/approval request Please approve this backport from JDK-17 that fixes an accessibility problem in Windows, where JMenuItem shortcuts were not properly read out. Low risk. Verified in Windows 10 with JAWS. |
/integrate |
/sponsor |
Going to push as commit bf78d9b.
Your commit was automatically rebased without conflicts. |
Backport of JDK-8339728 from 17u that solves some accessibility issues on Windows, for parity with 11.0.27/28-oracle (and because it's marked as CPU25-critical-SQE-OK too). Low risk.
The test does fail without this fix (when read-out, the short-cuts are truncated, so for instance the menu short-cut "Ctrl+Shift+Period" was read out as "Control plus Shift plus P", instead of "Control plus Shift plus Period".
The new accessibility test passes on Windows 10 (tested with JAWS v. 2025.2412.102 - February 2025 ).
Clean but for an update in copyright header and for a multi-line string (that has been replaced) in
AccessBridge.java
.Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/3001/head:pull/3001
$ git checkout pull/3001
Update a local copy of the PR:
$ git checkout pull/3001
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/3001/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 3001
View PR using the GUI difftool:
$ git pr show -t 3001
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/3001.diff
Using Webrev
Link to Webrev Comment