Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8315380: AsyncGetCallTrace crash in frame::safe_for_sender #3003

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

8315380: AsyncGetCallTrace crash in frame::safe_for_sender #3003

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3a89bf6
8315380: AsyncGetCallTrace crash in frame::safe_for_sender
jbachorik Feb 19, 2025
4d04026
Make proper fix: 'sp' -> 'unextended_sp' in the condition
jbachorik Mar 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/hotspot/cpu/aarch64/frame_aarch64.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
/*
* Copyright (c) 1997, 2021, Oracle and/or its affiliates. All rights reserved.
* Copyright (c) 2014, 2021, Red Hat Inc. All rights reserved.
* Copyrithg (c) 2025, Datadog, Inc. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
Expand Down Expand Up @@ -84,7 +85,8 @@ bool frame::safe_for_sender(JavaThread *thread) {
// So unextended sp must be within the stack but we need not to check
// that unextended sp >= sp

bool unextended_sp_safe = (unextended_sp < thread->stack_base());
bool unextended_sp_safe = (unextended_sp < thread->stack_base() && \
unextended_sp >= thread->stack_base() - thread->stack_size());

if (!unextended_sp_safe) {
return false;
Expand Down