Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8259268: Refactor InheritIO shell test as java test #3006

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sendaoYan
Copy link
Member

@sendaoYan sendaoYan commented Feb 27, 2025

Hi all,

This pull request contains a backport of commit fb46d4e5 from the openjdk/jdk repository.

The commit being backported was authored by Ivan Šipka on 6 Feb 2021 and was reviewed by Igor Ignatyev and Roger Riggs.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • JDK-8259268 needs maintainer approval
  • Commit message must refer to an issue

Issue

  • JDK-8259268: Refactor InheritIO shell test as java test (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/3006/head:pull/3006
$ git checkout pull/3006

Update a local copy of the PR:
$ git checkout pull/3006
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/3006/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3006

View PR using the GUI difftool:
$ git pr show -t 3006

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/3006.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 27, 2025

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Feb 27, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport fb46d4e578db297c66176852bec77fc3ad5b89a8 8259268: Refactor InheritIO shell test as java test Feb 27, 2025
@openjdk
Copy link

openjdk bot commented Feb 27, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Feb 27, 2025

⚠️ @sendaoYan This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 27, 2025
@mlbridge
Copy link

mlbridge bot commented Feb 27, 2025

Webrevs

@sendaoYan sendaoYan marked this pull request as draft February 27, 2025 06:17
@openjdk openjdk bot removed the rfr Pull request is ready for review label Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

1 participant