8309841: Jarsigner should print a warning if an entry is removed

[wkia]

This is backport of "8309841: Jarsigner should print a warning if an entry is removed"

Original patch does not apply cleanly to jdk11, some minor conflicts, and also in test/jdk/sun/security/tools/jarsigner/RemovedFiles.java ed25519 algorithm was replaced with RSA, and _ was replaced with a variable, and added the check in src/jdk.jartool/share/classes/sun/security/tools/jarsigner/Main.java at line 1259.

We need this fix in jdk11 and below, down to jdk8, as all versions have this issue with jarsigner.

New tests successfully ran locally on Linux, x86_64.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change requires CSR request JDK-8334261 to be approved
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8309841 needs maintainer approval

Issues

• JDK-8309841: Jarsigner should print a warning if an entry is removed (Enhancement - P3 - Requested)
• JDK-8334261: Jarsigner should print a warning if an entry is removed (CSR)

Reviewers

• Alexey Bakhtin (@alexeybakhtin - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/3007/head:pull/3007
$ git checkout pull/3007

Update a local copy of the PR:
$ git checkout pull/3007
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/3007/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3007

View PR using the GUI difftool:
$ git pr show -t 3007

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/3007.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back rmarchenko! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 01: Full - Incremental (49da1bb0)
• 00: Full (675ca9a0)

[wkia]

The test serviceability/sa/ClhsdbFindPC.java#id1 fails on Mac with timeout. I don't think it is related to the change.

[alexeybakhtin]

Thank you for the backport. LGTM

[openjdk]

⚠️ @wkia This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[wkia]

/approval request I'd like to backport this to 11u-dev. We need this fix in jdk11 and below, down to jdk8, as all versions have this issue with jarsigner. Original patch does not apply cleanly to jdk11, some minor conflicts resolved, tests adapted. New tests successfully ran locally on Linux, x86_64.

[openjdk]

@wkia
8309841: The approval request has been created successfully.