-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8309841: Jarsigner should print a warning if an entry is removed #3007
base: master
Are you sure you want to change the base?
Conversation
👋 Welcome back rmarchenko! A progress list of the required criteria for merging this PR into |
❗ This change is not yet ready to be integrated. |
This backport pull request has now been updated with issue from the original commit. |
Webrevs
|
The test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the backport. LGTM
|
/approval request I'd like to backport this to 11u-dev. We need this fix in jdk11 and below, down to jdk8, as all versions have this issue with jarsigner. Original patch does not apply cleanly to jdk11, some minor conflicts resolved, tests adapted. New tests successfully ran locally on Linux, x86_64. |
This is backport of "8309841: Jarsigner should print a warning if an entry is removed"
Original patch does not apply cleanly to jdk11, some minor conflicts, and also in
test/jdk/sun/security/tools/jarsigner/RemovedFiles.java
ed25519
algorithm was replaced withRSA
, and_
was replaced with a variable, and added the check insrc/jdk.jartool/share/classes/sun/security/tools/jarsigner/Main.java
at line 1259.We need this fix in jdk11 and below, down to jdk8, as all versions have this issue with jarsigner.
New tests successfully ran locally on Linux, x86_64.
Progress
Issues
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/3007/head:pull/3007
$ git checkout pull/3007
Update a local copy of the PR:
$ git checkout pull/3007
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/3007/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 3007
View PR using the GUI difftool:
$ git pr show -t 3007
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/3007.diff
Using Webrev
Link to Webrev Comment