Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8347629: Test FailOverDirectExecutionControlTest.java fails with -Xcomp #3008

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sendaoYan
Copy link
Member

@sendaoYan sendaoYan commented Mar 1, 2025

Hi all,

This pull request contains a backport of commit 981d3c2b from the jdk24u openjdk/jdk24u repository to jdk21u-dev repository.

The commit being backported was authored by SendaoYan on 1 Mar 2025.

Thanks!


Progress

  • JDK-8347629 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8347629: Test FailOverDirectExecutionControlTest.java fails with -Xcomp (Bug - P4 - Requested)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/3008/head:pull/3008
$ git checkout pull/3008

Update a local copy of the PR:
$ git checkout pull/3008
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/3008/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3008

View PR using the GUI difftool:
$ git pr show -t 3008

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/3008.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 1, 2025

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 1, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 981d3c2b6edb8ee8233be07cd1ce682200019d1f 8347629: Test FailOverDirectExecutionControlTest.java fails with -Xcomp Mar 1, 2025
@openjdk
Copy link

openjdk bot commented Mar 1, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Mar 1, 2025

⚠️ @sendaoYan This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 1, 2025
@mlbridge
Copy link

mlbridge bot commented Mar 1, 2025

Webrevs

@sendaoYan
Copy link
Member Author

GHA report 1 test failure:

  1. macos-x64 hs/tier1 serviceability job report Test serviceability/sa/ClhsdbFindPC.java#id1 fails, the intermittent fails has been recorded by https://bugs.openjdk.org/browse/JDK-8249150, it's unrelated to this backport PR.

@sendaoYan
Copy link
Member Author

/approval request Clean backport to fix the test bug which maybe cause test fails with -Xcomp option. Change has been verified locally, test-fix only, no risk.

@openjdk
Copy link

openjdk bot commented Mar 2, 2025

@sendaoYan
8347629: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Mar 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approval backport clean rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant