Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8327476: Upgrade JLine to 3.26.1 #3010

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vieiro
Copy link
Contributor

@vieiro vieiro commented Mar 11, 2025

Clean backport of JDK-8327476 from JDK17 that upgrades JLine to 3.26.1 (parity with 11.0.27-oracle). This is tagged as CPU25_04-critical-SQE-OK.

Tested with tier1 tests on Linux...

==============================
Test summary
==============================
   TEST                                              TOTAL  PASS  FAIL ERROR   
   jtreg:test/hotspot/jtreg:tier1                     1497  1497     0     0   
   jtreg:test/jdk:tier1                               1899  1899     0     0   
   jtreg:test/langtools:tier1                         3941  3941     0     0   
   jtreg:test/nashorn:tier1                              0     0     0     0   
   jtreg:test/jaxp:tier1                                 0     0     0     0   
==============================
TEST SUCCESS

And with the following on Linux and Windows 11:

==============================
Test summary
==============================
   TEST                                              TOTAL  PASS  FAIL ERROR   
   jtreg:test/jdk/jdk/internal/jline                     3     3     0     0   
==============================
TEST SUCCESS
==============================
Test summary
==============================
   TEST                                              TOTAL  PASS  FAIL ERROR   
   jtreg:test/langtools/jdk/jshell                      85    85     0     0   
==============================
TEST SUCCESS

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8327476 needs maintainer approval

Issue

  • JDK-8327476: Upgrade JLine to 3.26.1 (Task - P4 - Requested)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/3010/head:pull/3010
$ git checkout pull/3010

Update a local copy of the PR:
$ git checkout pull/3010
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/3010/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3010

View PR using the GUI difftool:
$ git pr show -t 3010

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/3010.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 11, 2025

👋 Welcome back vieiro! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 11, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport bb391d7a3656eda8864b777a9561a9e7e71a47a9 8327476: Upgrade JLine to 3.26.1 Mar 11, 2025
@openjdk
Copy link

openjdk bot commented Mar 11, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Mar 11, 2025

⚠️ @vieiro This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 11, 2025
@mlbridge
Copy link

mlbridge bot commented Mar 11, 2025

Webrevs

@vieiro
Copy link
Contributor Author

vieiro commented Mar 11, 2025

Test failure of ClhsdbFindPC on macos when ran with -XComp (run main/othervm/timeout=480 ClhsdbFindPC true true) is unrelated.

@vieiro
Copy link
Contributor Author

vieiro commented Mar 11, 2025

/approval request Please approve this upgrade to JLine to 3.26.1. Low/medium risk. Linux/Windows specific tests pass. This is labelled CPU25_04-critical-SQE-OK but didn't make it to the appropriate 25/04 window for 11 because it required rework on other JDK versions.

@openjdk
Copy link

openjdk bot commented Mar 11, 2025

@vieiro
8327476: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Mar 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approval backport clean rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant