Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8348596: Update FreeType to 2.13.3 #3011

Closed
wants to merge 1 commit into from

Conversation

vieiro
Copy link
Contributor

@vieiro vieiro commented Mar 11, 2025

Clean backport of JDK-8348596 that solves two important bug fixes, for parity with 11.0.28-oracle.

Passed tier1 tests on Linux.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8348596 needs maintainer approval

Issue

  • JDK-8348596: Update FreeType to 2.13.3 (Bug - P3 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/3011/head:pull/3011
$ git checkout pull/3011

Update a local copy of the PR:
$ git checkout pull/3011
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/3011/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3011

View PR using the GUI difftool:
$ git pr show -t 3011

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/3011.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 11, 2025

👋 Welcome back vieiro! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 11, 2025

@vieiro This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8348596: Update FreeType to 2.13.3

Reviewed-by: andrew

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • bf78d9b: 8339728: [Accessibility,Windows,JAWS] Bug in the getKeyChar method of the AccessBridge class
  • 624cef6: 8351099: Bump update version of OpenJDK: 11.0.28
  • 8785172: 8026976: ECParameters, Point does not match field size

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@gnu-andrew) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title Backport 682c9390339a79b89f82e580f90587deafbeef45 8348596: Update FreeType to 2.13.3 Mar 11, 2025
@openjdk
Copy link

openjdk bot commented Mar 11, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Mar 11, 2025

⚠️ @vieiro This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 11, 2025
@mlbridge
Copy link

mlbridge bot commented Mar 11, 2025

Webrevs

@vieiro
Copy link
Contributor Author

vieiro commented Mar 12, 2025

/approval request Please approve this backport to JDK11 that updates the FreeType library (fixing two important bugs), for parity with 11.0.28-oracle. Passes tier1 tests.

@openjdk
Copy link

openjdk bot commented Mar 12, 2025

@vieiro
8348596: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Mar 12, 2025
Copy link
Member

@gnu-andrew gnu-andrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Patch confirmed clean against 17u. MacOS test failure looks unrelated (HotSpot serviceability)

@gnu-andrew
Copy link
Member

/approve yes

@openjdk
Copy link

openjdk bot commented Mar 20, 2025

@gnu-andrew
8348596: The approval request has been approved.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Mar 20, 2025
@vieiro
Copy link
Contributor Author

vieiro commented Mar 20, 2025

Thanks for the approval, let's
/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Mar 20, 2025
@openjdk
Copy link

openjdk bot commented Mar 20, 2025

@vieiro
Your change (at version 459c2b6) is now ready to be sponsored by a Committer.

@jerboaa
Copy link
Contributor

jerboaa commented Mar 20, 2025

/sponsor

@openjdk
Copy link

openjdk bot commented Mar 20, 2025

Going to push as commit 428c2a292a8670f44bdb617014caaed0de591907.
Since your change was applied there have been 3 commits pushed to the master branch:

  • bf78d9b: 8339728: [Accessibility,Windows,JAWS] Bug in the getKeyChar method of the AccessBridge class
  • 624cef6: 8351099: Bump update version of OpenJDK: 11.0.28
  • 8785172: 8026976: ECParameters, Point does not match field size

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 20, 2025
@openjdk openjdk bot closed this Mar 20, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Mar 20, 2025
@openjdk
Copy link

openjdk bot commented Mar 20, 2025

@jerboaa @vieiro Pushed as commit 428c2a2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants