-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8348596: Update FreeType to 2.13.3 #3011
Conversation
👋 Welcome back vieiro! A progress list of the required criteria for merging this PR into |
@vieiro This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 3 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@gnu-andrew) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
This backport pull request has now been updated with issue from the original commit. |
|
/approval request Please approve this backport to JDK11 that updates the FreeType library (fixing two important bugs), for parity with 11.0.28-oracle. Passes tier1 tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Patch confirmed clean against 17u. MacOS test failure looks unrelated (HotSpot serviceability)
/approve yes |
@gnu-andrew |
Thanks for the approval, let's |
/sponsor |
Going to push as commit 428c2a292a8670f44bdb617014caaed0de591907.
Your commit was automatically rebased without conflicts. |
Clean backport of JDK-8348596 that solves two important bug fixes, for parity with 11.0.28-oracle.
Passed tier1 tests on Linux.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/3011/head:pull/3011
$ git checkout pull/3011
Update a local copy of the PR:
$ git checkout pull/3011
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/3011/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 3011
View PR using the GUI difftool:
$ git pr show -t 3011
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/3011.diff
Using Webrev
Link to Webrev Comment