-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8330846: Add stacks of mounted virtual threads to the HotSpot thread dump #1129
base: master
Are you sure you want to change the base?
8330846: Add stacks of mounted virtual threads to the HotSpot thread dump #1129
Conversation
👋 Welcome back jwtang! A progress list of the required criteria for merging this PR into |
❗ This change is not yet ready to be integrated. |
This backport pull request has now been updated with issue from the original commit. |
|
/approval request backport 8330846 to jdk21-dev because of two reasons.
|
@jia-wei-tang |
Hi @jia-wei-tang, |
Yes, It is needed. Should I backport JDK-8334215 in the same pr or create a new one? |
@GoeLin Hi, Should I backport JDK-8334215 in the same pr or create a new on after this merged? JDK-8330846 is the base of JDK-8334215, so I think both of them should be backported. |
@jia-wei-tang This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
Hi, could anyone approve this? |
Hi @jia-wei-tang, please inline JDK-8334215 into this PR, I think that would be best. Then we can review/approve this. Cheers |
@jia-wei-tang This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
I have two reasons to backport 8330846.
test/jdk/jdk/jfr/event/runtime/TestThreadDumpEvent.java
with the option-testThreadFactory:Virtual
, it will fail because of the loss ofTestThreadDumpEvent.main
in the result.Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1129/head:pull/1129
$ git checkout pull/1129
Update a local copy of the PR:
$ git checkout pull/1129
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1129/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1129
View PR using the GUI difftool:
$ git pr show -t 1129
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1129.diff
Using Webrev
Link to Webrev Comment