Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8337998: CompletionFailure in getEnclosingType attaching type annotations #1253

Open
wants to merge 1 commit into
base: pr/1252
Choose a base branch
from

Conversation

cushon
Copy link
Contributor

@cushon cushon commented Dec 17, 2024

This is a backport of JDK-8337998, which is a follow-up to JDK-8225377.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8337998 needs maintainer approval

Integration blocker

 ⚠️ Dependency #1252 must be integrated first

Issue

  • JDK-8337998: CompletionFailure in getEnclosingType attaching type annotations (Bug - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1253/head:pull/1253
$ git checkout pull/1253

Update a local copy of the PR:
$ git checkout pull/1253
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1253/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1253

View PR using the GUI difftool:
$ git pr show -t 1253

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1253.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 17, 2024

👋 Welcome back cushon! A progress list of the required criteria for merging this PR into pr/1252 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 17, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 9e282e5c966a9c065de8b901b7d30bb5c9ccf243 8337998: CompletionFailure in getEnclosingType attaching type annotations Dec 17, 2024
@openjdk
Copy link

openjdk bot commented Dec 17, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport clean rfr Pull request is ready for review labels Dec 17, 2024
@mlbridge
Copy link

mlbridge bot commented Dec 17, 2024

Webrevs

Copy link

@vicente-romero-oracle vicente-romero-oracle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@openjdk openjdk bot removed the clean label Jan 9, 2025
@openjdk
Copy link

openjdk bot commented Jan 9, 2025

⚠️ @cushon This pull request contains merges that bring in commits not present in the target repository. Since this is not a "merge style" pull request, these changes will be squashed when this pull request in integrated. If this is your intention, then please ignore this message. If you want to preserve the commit structure, you must change the title of this pull request to Merge <project>:<branch> where <project> is the name of another project in the OpenJDK organization (for example Merge jdk:master).

@cushon cushon force-pushed the backport-JDK-8337998 branch from 6897ea0 to 1abdbdb Compare January 9, 2025 15:47
@openjdk
Copy link

openjdk bot commented Jan 9, 2025

@cushon Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 3, 2025

@cushon This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@cushon
Copy link
Contributor Author

cushon commented Feb 3, 2025

Please keep this open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

2 participants