Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8346671: java/nio/file/Files/probeContentType/Basic.java fails on Windows 2025 #1377

Closed

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Jan 30, 2025

I backport this for parity with 21.0.7-oracle.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8346671 needs maintainer approval

Issue

  • JDK-8346671: java/nio/file/Files/probeContentType/Basic.java fails on Windows 2025 (Bug - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1377/head:pull/1377
$ git checkout pull/1377

Update a local copy of the PR:
$ git checkout pull/1377
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1377/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1377

View PR using the GUI difftool:
$ git pr show -t 1377

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1377.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 30, 2025

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jan 30, 2025

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8346671: java/nio/file/Files/probeContentType/Basic.java fails on Windows 2025

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 18 new commits pushed to the master branch:

  • 9c8fe67: 8349603: [21u, 17u, 11u] Update GHA JDKs after Jan/25 updates
  • 46a1464: 8348562: ZGC: segmentation fault due to missing node type check in barrier elision analysis
  • d279d44: 8340411: open source several 2D imaging tests
  • 4a3eaa7: 8330702: Update failure handler to don't generate Error message if cores actions are empty
  • 29a5de0: 8334371: [AIX] Beginning with AIX 7.3 TL1 mmap() supports 64K memory pages
  • 981ec16: 8347911: Limit the length of inflated text chunks
  • caa7cc2: 8338571: [TestBug] DefaultCloseOperation.java test not working as expected wrt instruction after JDK-8325851 fix
  • 80253a3: 8343491: javax/management/remote/mandatory/connection/DeadLockTest.java failing with NoSuchObjectException: no such object in table
  • d0fbffd: 8226938: [TEST_BUG]GTK L&F: There is no Details button in FileChooser Dialog
  • 9a2988c: 8340078: Open source several 2D tests
  • ... and 8 more: https://git.openjdk.org/jdk21u-dev/compare/95e4bc9e201f8643d21bd9fe6fc180951bbcd1e7...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 2e00816ac30373df28a29dc938f7ce5489a3edfc 8346671: java/nio/file/Files/probeContentType/Basic.java fails on Windows 2025 Jan 30, 2025
@openjdk
Copy link

openjdk bot commented Jan 30, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jan 30, 2025

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 30, 2025
@mlbridge
Copy link

mlbridge bot commented Jan 30, 2025

Webrevs

@openjdk openjdk bot added the approval label Jan 31, 2025
@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Feb 11, 2025
@GoeLin
Copy link
Member Author

GoeLin commented Feb 11, 2025

/integrate

@openjdk
Copy link

openjdk bot commented Feb 11, 2025

Going to push as commit e122829dcacb494fbe9668d454b49a256c1640a4.
Since your change was applied there have been 18 commits pushed to the master branch:

  • 9c8fe67: 8349603: [21u, 17u, 11u] Update GHA JDKs after Jan/25 updates
  • 46a1464: 8348562: ZGC: segmentation fault due to missing node type check in barrier elision analysis
  • d279d44: 8340411: open source several 2D imaging tests
  • 4a3eaa7: 8330702: Update failure handler to don't generate Error message if cores actions are empty
  • 29a5de0: 8334371: [AIX] Beginning with AIX 7.3 TL1 mmap() supports 64K memory pages
  • 981ec16: 8347911: Limit the length of inflated text chunks
  • caa7cc2: 8338571: [TestBug] DefaultCloseOperation.java test not working as expected wrt instruction after JDK-8325851 fix
  • 80253a3: 8343491: javax/management/remote/mandatory/connection/DeadLockTest.java failing with NoSuchObjectException: no such object in table
  • d0fbffd: 8226938: [TEST_BUG]GTK L&F: There is no Details button in FileChooser Dialog
  • 9a2988c: 8340078: Open source several 2D tests
  • ... and 8 more: https://git.openjdk.org/jdk21u-dev/compare/95e4bc9e201f8643d21bd9fe6fc180951bbcd1e7...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 11, 2025
@openjdk openjdk bot closed this Feb 11, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 11, 2025
@openjdk
Copy link

openjdk bot commented Feb 11, 2025

@GoeLin Pushed as commit e122829.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant