Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strict final fields #1343

Closed
wants to merge 1 commit into from
Closed

Conversation

matias9927
Copy link
Contributor

@matias9927 matias9927 commented Jan 30, 2025


Progress

  • Change must not contain extraneous whitespace

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/valhalla.git pull/1343/head:pull/1343
$ git checkout pull/1343

Update a local copy of the PR:
$ git checkout pull/1343
$ git pull https://git.openjdk.org/valhalla.git pull/1343/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1343

View PR using the GUI difftool:
$ git pr show -t 1343

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/valhalla/pull/1343.diff

Sorry, something went wrong.

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 30, 2025

👋 Welcome back matsaave! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jan 30, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk
Copy link

openjdk bot commented Jan 30, 2025

⚠️ @matias9927 This pull request contains merges that bring in commits not present in the target repository. Since this is not a "merge style" pull request, these changes will be squashed when this pull request in integrated. If this is your intention, then please ignore this message. If you want to preserve the commit structure, you must change the title of this pull request to Merge <project>:<branch> where <project> is the name of another project in the OpenJDK organization (for example Merge jdk:master).

@liach
Copy link
Member

liach commented Jan 31, 2025

Does this depend on #1333?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants