Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add some content for .github openjsf profile #1

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

andostronaut
Copy link

This PR adds initial content for the .github repository to enhance the OpenJS Foundation profile. It includes a profile/README.md with basic information about the organization.

Copy link
Member

@evenstensberg evenstensberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! Left some comments ⭐

@andostronaut
Copy link
Author

Thanks for the feedback @evenstensberg

Copy link
Member

@evenstensberg evenstensberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ljharb
Copy link
Member

ljharb commented Feb 26, 2025

instead of including the logo here, could you reference https://github.com/openjs-foundation/artwork/blob/HEAD/openjs_foundation/openjs_foundation-icon-color.svg ?

@andostronaut
Copy link
Author

I've pushed some modifications @ljharb

@ljharb
Copy link
Member

ljharb commented Feb 26, 2025

LGTM, but unfortunately https://github.com/andostronaut/openjs-foundation.github/tree/feat/add-some-content-profile suggests the symlink won't work :-/

@andostronaut
Copy link
Author

@ljharb I've tested some workarounds, but none of them work with the GitHub README. We can stick with the duplication for now. I'll look for some solutions in the meantime

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants