Updated python dependencies & configurable docker builds #325
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Running different versions of the OpenML website: one in production (k8s), one in test.
To make that possible, all urls should be configurable, both in the Python backend as in the React frontend.
Changes
In this PR (sorry, I could've splitted it in separate PRs):
pandas
does not allowdf.append
, while no version ofpandas
was specified). Also, many dependencies in requirements.txt were dependencies of dependencies - I removed them..flaskenv
to.env
(easy to use for both react and flask), renamed some and added some (e.g.,DO_SEND_EMAIL
)REACT_APP_ELASTICSEARCH_VERSION_MAYOR
Similar to PR 274
This PR is duplicate with most of the work of PR #274. I took the liberty to take inspiration from that PR, but not use it directly, because it's old. We should probably close that PR if we merge this - although there are some additions in that PR that I did not include here:
DataUpload.js
: uselicense
instead ofevent.target.license.value
https://github.com/openml/openml.org/pull/274/files#diff-ca4185fadad75cdffb33285013b312dddf85808446933a35a9c1c9fbd5bebc88L107Profile.js
andProfilePage.js
These changes should probably be in a separate PR (?)
How to test
The python unittests seemed to not be up-to-date. They didn't seem to be easily runnable, and the coverage seemed small. I ignored them (let me know if they should be up-to-date).
I tested this by running it locally (the
.env
variant) and deploying it to https://k8s.openml.org (the.env.k8s
variant), and:Current deployment
Docker image
openml/frontend:k8s
(see https://hub.docker.com/r/openml/frontend/tags) runs on https://k8s.openml.org/. Docker imageopenml/frontent:latest
is currently not used (it could be used for the current production). I didn't create a test image yet, I'll do that in a separate PR.