[resolver] WIP Utility to resolve AQ csv and GPD log trace dailies #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apengwin
reviewed
Jun 13, 2018
python/resolver/load.py
Outdated
| return select | ||
|
|
||
|
|
||
| def load(target_day_dir: str) -> Dict[str, pd.DataFrame]: |
There was a problem hiding this comment.
oh my god function annotations. i am not ready for this
|
This looks awesome. Hope we can discuss soon. Let me know if you can make it on Tuesday, otherwise we can try for a call? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intent: Develop a contained ETL process through which the following is achieved:
cli.pyinterface to enable command line invocation of ETL processOpen questions:
.logand.csvfiles in UTC GMT? If not, then what?pre-commitchecks? What development environment is desired? Should I set up a base Dockerfile from which to run this stuff? Does one already exist?Why submit PR early?