Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable linters in CI - Shell, Python #59

Merged
merged 3 commits into from
Apr 25, 2024
Merged

Enable linters in CI - Shell, Python #59

merged 3 commits into from
Apr 25, 2024

Conversation

jamacku
Copy link
Contributor

@jamacku jamacku commented Apr 24, 2024

No description provided.

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@kdudka
Copy link
Member

kdudka commented Apr 25, 2024

@jamacku Did the CI job actually scan anything? The list of scripts for scanning at https://github.com/openscanhub/fedora-infra/pull/59/checks#step:4:27 is empty but if I run shellcheck locally, it gives me some results:

% shellcheck containers/scripts/run_hub.sh

In containers/scripts/run_hub.sh line 4:
if [[ -e /src ]]; then
   ^-----------^ SC3010 (warning): In POSIX sh, [[ ]] is undefined.


In containers/scripts/run_hub.sh line 6:
    pushd /src
    ^--------^ SC3044 (warning): In POSIX sh, 'pushd' is undefined.


In containers/scripts/run_hub.sh line 16:
    popd
    ^--^ SC3044 (warning): In POSIX sh, 'popd' is undefined.


In containers/scripts/run_hub.sh line 47:
if [[ -e /src ]]; then
   ^-----------^ SC3010 (warning): In POSIX sh, [[ ]] is undefined.


In containers/scripts/run_hub.sh line 54:
    python3 -m smtpd -n -c DebuggingServer localhost:8025 &> /tmp/emails.log &
                                                          ^----------------^ SC3020 (warning): In POSIX sh, &> is undefined.

For more information:
  https://www.shellcheck.net/wiki/SC3010 -- In POSIX sh, [[ ]] is undefined.
  https://www.shellcheck.net/wiki/SC3020 -- In POSIX sh, &> is undefined.
  https://www.shellcheck.net/wiki/SC3044 -- In POSIX sh, 'popd' is undefined.

@kdudka
Copy link
Member

kdudka commented Apr 25, 2024

As explained in person, the list of shell scripts covered by the CI is available here: https://github.com/jamacku/fedora-infra/actions/runs/8820241956/job/24213397008#step:4:28 This pull request does not change any of them, so the list of scripts to scan ended up empty.

@jamacku
Copy link
Contributor Author

jamacku commented Apr 25, 2024

Screenshot from 2024-04-25 10-12-49

@siteshwar siteshwar merged commit ee8d7fd into openscanhub:main Apr 25, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants