Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Remote Store] Abstract out remote segment garbage collection logic #13221

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sachinpkale
Copy link
Member

@sachinpkale sachinpkale commented Apr 16, 2024

Description

  • Currently, remote segment garbage collection is tightly coupled with RemoteStoreRefreshListener and has a fixed logic where the deletion is triggered post commit.
  • Ideally, garbage collection should be a separate flow and should not be coupled with RemoteStoreRefreshListener.
  • It is also possible to have different triggers to the garbage collection like time based, size based etc.
  • It shold also be possible to turn off the garbage collection completely where user wants to control it externally.
  • In this PR, logic for remote segment garbage collection is abstracted out from RemoteStoreRefreshListener.

Related Issues

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@sachinpkale sachinpkale changed the title [Remote Store] Abstract out remote segemnt garbage collection logic [Remote Store] Abstract out remote segment garbage collection logic Apr 16, 2024
Copy link
Contributor

Compatibility status:

Checks if related components are compatible with change cc805f9

Incompatible components

Skipped components

Compatible components

Copy link
Contributor

❌ Gradle check result for cc805f9: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for cc805f9: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Comment on lines +25 to +28
/**
* Called on skipping the garbage collection
*/
void onSkip(String reason);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe a better contract would be shouldGarbageCollect() that returns a boolean. We can add additional safety constraints explicitly

@opensearch-trigger-bot
Copy link
Contributor

This PR is stalled because it has been open for 30 days with no activity.

@opensearch-trigger-bot opensearch-trigger-bot bot added the stalled Issues that have stalled label May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog stalled Issues that have stalled
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants