Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Forwardport] Snapshot _status API to return correct status for partial snapshots (update version) #13262

Merged
merged 1 commit into from
Apr 17, 2024

Conversation

reta
Copy link
Collaborator

@reta reta commented Apr 17, 2024

Description

Forwardport of #13260 to main

Related Issues

N/A

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@reta reta changed the title [Forwardport] Snapshot _status API to return correct status for partial snapshots (… [Forwardport] Snapshot _status API to return correct status for partial snapshots (update version) Apr 17, 2024
Copy link
Contributor

❕ Gradle check result for e72cd3f: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.cluster.MinimumClusterManagerNodesIT.testThreeNodesNoClusterManagerBlock

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link

codecov bot commented Apr 17, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 71.56%. Comparing base (b15cb0c) to head (e72cd3f).
Report is 187 commits behind head on main.

Files Patch % Lines
...va/org/opensearch/cluster/SnapshotsInProgress.java 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #13262      +/-   ##
============================================
+ Coverage     71.42%   71.56%   +0.14%     
- Complexity    59978    60738     +760     
============================================
  Files          4985     5040      +55     
  Lines        282275   285456    +3181     
  Branches      40946    41338     +392     
============================================
+ Hits         201603   204280    +2677     
- Misses        63999    64346     +347     
- Partials      16673    16830     +157     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@owaiskazi19
Copy link
Member

@reta for my understanding, why didn't we make this change in the initial PR itself? Because the backport 2.x PR had V_2_14_0 version check? So we could have done this change in the main branch and backport the same to 2.x?

@reta
Copy link
Collaborator Author

reta commented Apr 17, 2024

@reta for my understanding, why didn't we make this change in the initial PR itself? Because the backport 2.x PR had V_2_14_0 version check? So we could have done this change in the main branch and backport the same to 2.x?

@owaiskazi19 In general, the mixed cluster tests fail (because 3.x makes an assumption that 2.x knows more than it does).

Copy link
Member

@owaiskazi19 owaiskazi19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @reta for taking care of this.

@reta reta merged commit 84679de into opensearch-project:main Apr 17, 2024
56 of 78 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants