Fix infinite loop in nested agg

[kkewwei]

Description

Fix infinite loop in nested agg

Related Issues

Resolves #15914

Check List

• Functionality includes testing.
• API changes companion pull request created, if applicable.
• Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[github-actions]

❌ Gradle check result for 961eb49: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions]

❌ Gradle check result for bbd4aa8: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[kkewwei]

If you are bored while gradle re-runs, you could add some tests for agg to https://github.com/opensearch-project/opensearch-api-specification and potentially fix any API spec problems with that ;)

Of course, let me have a try.

[github-actions]

❌ Gradle check result for 693c69b: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions]

❕ Gradle check result for ab0d430: UNSTABLE

• TEST FAILURES:

      1 org.opensearch.remotestore.multipart.RemoteStoreMultipartIT.testNoSearchIdleForAnyReplicaCount

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

[kkewwei]

❕ Gradle check result for ab0d430: UNSTABLE

• TEST FAILURES:

      1 org.opensearch.remotestore.multipart.RemoteStoreMultipartIT.testNoSearchIdleForAnyReplicaCount

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

org.opensearch.remotestore.multipart.RemoteStoreMultipartIT #11997

[github-actions]

✅ Gradle check result for 3953557: SUCCESS

[dbwiddis]

LGTM. I will approve when the checklist at the top of this PR is completed. Certainly there is testing (box 1) and an API spec (box 2) and it may not need a doc fix (box 3) but I'd prefer to see that assessment done by the PR submitter.

[opensearch-trigger-bot]

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-15931-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 6bef1e1d8e2dda8d88c2c8f2a7875b492239a480
# Push it to GitHub
git push --set-upstream origin backport/backport-15931-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-15931-to-2.x.

[reta]

@kkewwei the issue seems to be not fixed, here is the recent failure (with this pull request merged): #15914 (comment)