Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Integration Tests for Workload Management CRUD APIs #15955

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ruai0511
Copy link
Contributor

@ruai0511 ruai0511 commented Sep 16, 2024

Add Integration Tests for workload management CRUD APIs in plugin
For more information regarding workload management, refer to this RFC: #12342.

This IT can be run using

./gradlew ':plugins:workload-management:javaRestTest' \
  --tests "org.opensearch.rest.WorkloadManagementRestIT"

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@ruai0511 ruai0511 added the backport 2.x Backport to 2.x branch label Sep 16, 2024
@ruai0511 ruai0511 changed the title Add Integration Tests for workload management CRUD APIs Add Integration Tests for Workload Management CRUD APIs Sep 16, 2024
Copy link
Contributor

❌ Gradle check result for 4b0f7a0: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 870aff0: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 7f88472: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

@sandeshkr419 sandeshkr419 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can refactor some request bodies with json utilities to make these tests more readable:

 public static String getCreateJson(String name, String resiliencyMode, double cpu, double memory) {
        return "{\n" +
            "    \"name\": \"" + name + "\",\n" +
            "    \"resiliency_mode\": \"" + resiliencyMode + "\",\n" +
            "    \"resource_limits\": {\n" +
            "        \"cpu\" : " + cpu + ",\n" +
            "        \"memory\" : " + memory + "\n" +
            "    }\n" +
            "}";
    }

    public static String getUpdateJson(String resiliencyMode, double cpu, double memory) {
        return "{\n" +
            "    \"resiliency_mode\": \"" + resiliencyMode + "\",\n" +
            "    \"resource_limits\": {\n" +
            "        \"cpu\" : " + cpu + ",\n" +
            "        \"memory\" : " + memory + "\n" +
            "    }\n" +
            "}";
    }

Signed-off-by: Ruirui Zhang <[email protected]>
Copy link
Contributor

❕ Gradle check result for f81637f: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link

codecov bot commented Sep 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.87%. Comparing base (92d7fe8) to head (f81637f).
Report is 18 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #15955      +/-   ##
============================================
- Coverage     71.90%   71.87%   -0.03%     
- Complexity    64216    64242      +26     
============================================
  Files          5272     5277       +5     
  Lines        300597   300691      +94     
  Branches      43440    43449       +9     
============================================
- Hits         216151   216133      -18     
- Misses        66680    66816     +136     
+ Partials      17766    17742      -24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants