-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Integration Tests for Workload Management CRUD APIs #15955
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Ruirui Zhang <[email protected]>
❌ Gradle check result for 4b0f7a0: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for 870aff0: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for 7f88472: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can refactor some request bodies with json utilities to make these tests more readable:
public static String getCreateJson(String name, String resiliencyMode, double cpu, double memory) {
return "{\n" +
" \"name\": \"" + name + "\",\n" +
" \"resiliency_mode\": \"" + resiliencyMode + "\",\n" +
" \"resource_limits\": {\n" +
" \"cpu\" : " + cpu + ",\n" +
" \"memory\" : " + memory + "\n" +
" }\n" +
"}";
}
public static String getUpdateJson(String resiliencyMode, double cpu, double memory) {
return "{\n" +
" \"resiliency_mode\": \"" + resiliencyMode + "\",\n" +
" \"resource_limits\": {\n" +
" \"cpu\" : " + cpu + ",\n" +
" \"memory\" : " + memory + "\n" +
" }\n" +
"}";
}
Signed-off-by: Ruirui Zhang <[email protected]>
❕ Gradle check result for f81637f: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #15955 +/- ##
============================================
- Coverage 71.90% 71.87% -0.03%
- Complexity 64216 64242 +26
============================================
Files 5272 5277 +5
Lines 300597 300691 +94
Branches 43440 43449 +9
============================================
- Hits 216151 216133 -18
- Misses 66680 66816 +136
+ Partials 17766 17742 -24 ☔ View full report in Codecov by Sentry. |
Add Integration Tests for workload management CRUD APIs in plugin
For more information regarding workload management, refer to this RFC: #12342.
This IT can be run using
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.