Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Implement WithFieldName interface in ValuesSourceAggregationBuilder & FieldSortBuilder #15970

Merged

Conversation

dzane17
Copy link
Contributor

@dzane17 dzane17 commented Sep 18, 2024

Description

2.x Backport of #15916

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

❌ Gradle check result for ff49481: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@jainankitk
Copy link
Collaborator

Ideally shouldn't be a breaking change, since we;re just implementing the new interface. @dzane17 - Can you try to understand why detect-breaking-change is failing?

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':server:japicmp'.
> A failure occurred while executing me.champeau.gradle.japicmp.JApiCmpWorkAction
   > Detected binary changes.
         - current: opensearch-2.18.0-SNAPSHOT.jar
         - baseline: opensearch-2.17.0.jar.
     
     See failure report at file:///home/runner/work/OpenSearch/OpenSearch/server/build/reports/java-compatibility/report.html

@dzane17 dzane17 force-pushed the backport/backport-15916-to-2.x branch from ff49481 to f35a646 Compare September 18, 2024 19:07
Copy link
Contributor

❌ Gradle check result for f35a646: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@dzane17 dzane17 closed this Sep 18, 2024
@dzane17 dzane17 reopened this Sep 18, 2024
@dzane17
Copy link
Contributor Author

dzane17 commented Sep 18, 2024

@jainankitk detect-breaking-change passes now. There was an issue and fix unrelated to this PR. Waiting for flaky tests to pass now.

Copy link
Contributor

❌ Gradle check result for f35a646: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for f35a646: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for f35a646: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@jainankitk
Copy link
Collaborator

jainankitk commented Sep 19, 2024

❌ Gradle check result for f35a646: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Seems related to #9401:

[Test Result](https://build.ci.opensearch.org/job/gradle-check/48025/testReport/) (1 failure / +1)

    [org.opensearch.search.SearchTimeoutIT.testSimpleTimeout {p0={"search.concurrent_segment_search.enabled":"true"}}](https://build.ci.opensearch.org/job/gradle-check/48025/testReport/junit/org.opensearch.search/SearchTimeoutIT/testSimpleTimeout__p0___search_concurrent_segment_search_enabled___true___/)

Copy link
Contributor

❌ Gradle check result for f35a646: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

… FieldSortBuilder (opensearch-project#15916)

Signed-off-by: David Zane <[email protected]>
(cherry picked from commit 7c427d9)
@dzane17 dzane17 force-pushed the backport/backport-15916-to-2.x branch from f35a646 to db8872f Compare September 19, 2024 18:02
Copy link
Contributor

❌ Gradle check result for db8872f: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

✅ Gradle check result for db8872f: SUCCESS

Copy link

codecov bot commented Sep 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.70%. Comparing base (a15a20d) to head (db8872f).
Report is 1 commits behind head on 2.x.

Additional details and impacted files
@@             Coverage Diff              @@
##                2.x   #15970      +/-   ##
============================================
- Coverage     71.76%   71.70%   -0.06%     
+ Complexity    64687    64660      -27     
============================================
  Files          5277     5277              
  Lines        302318   302350      +32     
  Branches      43993    43996       +3     
============================================
- Hits         216953   216805     -148     
- Misses        67268    67436     +168     
- Partials      18097    18109      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants