-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport 2.x] Implement WithFieldName interface in ValuesSourceAggregationBuilder & FieldSortBuilder #15970
[Backport 2.x] Implement WithFieldName interface in ValuesSourceAggregationBuilder & FieldSortBuilder #15970
Conversation
❌ Gradle check result for ff49481: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Ideally shouldn't be a breaking change, since we;re just implementing the new interface. @dzane17 - Can you try to understand why
|
ff49481
to
f35a646
Compare
❌ Gradle check result for f35a646: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
@jainankitk |
❌ Gradle check result for f35a646: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for f35a646: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for f35a646: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Seems related to #9401:
|
❌ Gradle check result for f35a646: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
… FieldSortBuilder (opensearch-project#15916) Signed-off-by: David Zane <[email protected]> (cherry picked from commit 7c427d9)
f35a646
to
db8872f
Compare
❌ Gradle check result for db8872f: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.x #15970 +/- ##
============================================
- Coverage 71.76% 71.70% -0.06%
+ Complexity 64687 64660 -27
============================================
Files 5277 5277
Lines 302318 302350 +32
Branches 43993 43996 +3
============================================
- Hits 216953 216805 -148
- Misses 67268 67436 +168
- Partials 18097 18109 +12 ☔ View full report in Codecov by Sentry. |
Description
2.x Backport of #15916
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.