-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix search_as_you_type not supporting multi-fields #15988
base: main
Are you sure you want to change the base?
Fix search_as_you_type not supporting multi-fields #15988
Conversation
Signed-off-by: Gao Binlong <[email protected]>
Signed-off-by: Gao Binlong <[email protected]>
❌ Gradle check result for 46195e5: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for 087bf27: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Gao Binlong <[email protected]>
❌ Gradle check result for 605d96d: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #15988 +/- ##
============================================
+ Coverage 71.92% 71.97% +0.05%
+ Complexity 64400 64370 -30
============================================
Files 5281 5281
Lines 300995 300997 +2
Branches 43479 43479
============================================
+ Hits 216491 216654 +163
+ Misses 66793 66554 -239
- Partials 17711 17789 +78 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Gao Binlong <[email protected]>
fa76419
to
b98cda7
Compare
❕ Gradle check result for b98cda7: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Signed-off-by: Gao Binlong <[email protected]>
❌ Gradle check result for c4c8fb1: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for c4c8fb1: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Description
Now
search_as_you_type
ignores thefields
parameter specified in the mapping, the reason is thatSearchAsYouTypeFieldMapper
doesn't resolve that parameter, this PR fixes the bug.Related Issues
#5035
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.