Fix empty request body on retries with compression enabled #543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merlinz01
requested review from
dblock,
VijayanB,
VachaShah and
Jakob3xD
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #543 +/- ##
===========================================
+ Coverage 57.29% 67.96% +10.67%
===========================================
Files 315 376 +61
Lines 9823 8853 -970
===========================================
+ Hits 5628 6017 +389
+ Misses 2902 1555 -1347
+ Partials 1293 1281 -12
Flags with carried forward coverage won't be shown. Click here to find out more.
|
merlinz01
changed the title
dblock
previously approved these changes
May 13, 2024
dblock
reviewed
May 13, 2024
|
@merlinz01 Looks like you need to fix DCO ( |
dblock
reviewed
May 14, 2024
CHANGELOG.md
Outdated
| @@ -17,6 +17,8 @@ Inspired from [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) | |||
|
|
|||
| ### Fixed | |||
|
|
|||
| - Fixes empty request body on retry with compression enabled. ([#543](https://github.com/opensearch-project/opensearch-go/pull/543)) | |||
There was a problem hiding this comment.
Nit: remove period at the end of the sentence, other lines don't have it.
merlinz01
force-pushed
the
fix-empty-compressed-request-body-on-retry
branch
from
84d6484
to
c8722af
Compare
Signed-off-by: merlinz01 <[email protected]>
Signed-off-by: merlinz01 <[email protected]>
Signed-off-by: merlinz01 <[email protected]>
Signed-off-by: merlinz01 <[email protected]>
merlinz01
force-pushed
the
fix-empty-compressed-request-body-on-retry
branch
from
c8722af
to
e7ede90
Compare
|
DCO successful. |
dblock
approved these changes
May 14, 2024
|
Thanks! We have lots of other things in https://github.com/opensearch-project/opensearch-go/issues if you have free time :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Make the transport use a new reader for each retry when gzip compression is enabled.
Also be more explicit about doing so for non-compressed requests.
Test included.
Issues Resolved
Closes #541.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.