Fix: integration tests with unreleased version of OpenSearch. #600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: dblock <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #600 +/- ##
===========================================
+ Coverage 57.29% 67.99% +10.70%
===========================================
Files 315 376 +61
Lines 9823 8862 -961
===========================================
+ Hits 5628 6026 +398
+ Misses 2902 1555 -1347
+ Partials 1293 1281 -12
Flags with carried forward coverage won't be shown. Click here to find out more. |
Signed-off-by: dblock <[email protected]>
|
I am confused to how this passed before and is failing now. @Jakob3xD maybe? |
|
Got this endpoint maybe removed in the upstream Opensearch? |
dblock
force-pushed
the
fix-integration-unreleased
branch
2 times, most recently
from
e0b86f4
to
f4454ee
Compare
It's the other way around. The The reason why tests were passing in 1.x before is because we were actually running against OpenSearch 3.x (main). The workflow is simply incorrect and uses after the fix we correctly pickup the 1.x branch |
dblock
force-pushed
the
fix-integration-unreleased
branch
4 times, most recently
from
7bf5ad3
to
ad74978
Compare
Signed-off-by: dblock <[email protected]>
dblock
force-pushed
the
fix-integration-unreleased
branch
from
ad74978
to
3e3fefd
Compare
|
@Jakob3xD this is ready |
Jakob3xD
approved these changes
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Similar to opensearch-project/opensearch-py#798, needs a different JDK depending on branch.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.