Fix signer receiving a drained body on retries #620
+50
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aouji
requested review from
dblock,
VijayanB,
VachaShah and
Jakob3xD
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #620 +/- ##
===========================================
- Coverage 57.29% 15.37% -41.92%
===========================================
Files 315 316 +1
Lines 9823 7751 -2072
===========================================
- Hits 5628 1192 -4436
- Misses 2902 6476 +3574
+ Partials 1293 83 -1210
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: Arash Ouji <[email protected]>
aouji
force-pushed
the
bugfix/signing-on-retry
branch
from
e485819
to
f6a14dd
Compare
|
I'm not sure why integration tests are failing. Doesn't seem related to my change. BTW sorry for the mess I seem to have created in this PR. I can't re-trigger DCO and code coverage checks. Please trigger on your side or let me know if I need to close this and open a new PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When retrying, the body can be drained, and there is already code that resets the request body on retries. The issue was that we were sending the drained request to the signer before reseting the request body, so signature would be based on an empty body
Issues Resolved
#202
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.