Updating go version to 1.22.0 #733
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunsrin
requested review from
idanl21,
dbason,
swoehrl-mw,
prudhvigodithi,
jochenkressin,
pchmielnik and
salyh
as code owners
prudhvigodithi
approved these changes
Feb 26, 2024
|
Thanks for your contribution @sunsrin. |
|
@sunsrin there is other places to update go version, can you please check https://github.com/search?q=repo%3Aopensearch-project%2Fopensearch-k8s-operator%201.19&type=code ? |
### Description Fix the error running Functional tests with open PR's. ``` Error: No matching K3s versions were found. Error: Process completed with exit code 1 ``` Example: https://github.com/opensearch-project/opensearch-k8s-operator/actions/runs/7890709537/job/21543655443?pr=728 ### Issues Resolved _List any issues this PR will resolve, e.g. Closes [...]._ By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check [here](https://github.com/opensearch-project/OpenSearch/blob/main/CONTRIBUTING.md#developer-certificate-of-origin). Signed-off-by: Prudhvi Godithi <[email protected]> Signed-off-by: Sunil <[email protected]>
Signed-off-by: Sunil <[email protected]>
Update across the project to go 1.22.0 Signed-off-by: Sunil <[email protected]>
…ler (#727) Fixes #633 Fixes #731 Based on investigations [here](#633 (comment)) and [here](#731 (comment)) it was found that a discrepancy between `<nil slice>` and `<[] slice>` is causing the operator to constantly update User, Role, IndexTemplate, etc. Also, the current log level for User reconciles produces too many logs, so increasing its level may be a good idea here. Because of the issue with comparing `nil` and empty slices, I have replaced `reflect.DeepEqual` with `comp.Equal`. Also, added a helper function that will sort nested json keys in cases when API returns unsorted keys which is casing comparing to return diff. Closes #633 Closes #731 By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check [here](https://github.com/opensearch-project/OpenSearch/blob/main/CONTRIBUTING.md#developer-certificate-of-origin). --------- Signed-off-by: Yevhenii Tiutiunnyk <[email protected]>
### Description This PR adds a warning to make users aware of the 1-year validity time of operator-generated certificates. When documentation for renewing the certificates is available, it would be good to add link to it from here. ### Issues Resolved N/A By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check [here](https://github.com/opensearch-project/OpenSearch/blob/main/CONTRIBUTING.md#developer-certificate-of-origin). --------- Signed-off-by: Trond Hindenes <[email protected]> Signed-off-by: Prudhvi Godithi <[email protected]> Co-authored-by: Prudhvi Godithi <[email protected]> Signed-off-by: Sunil <[email protected]>
### Description This removes hardcoding of the timeouts and thresholds of probes used in nodepools. ### Issues Resolved Closes [418](#418) Closes [691](#691) By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check [here](https://github.com/opensearch-project/OpenSearch/blob/main/CONTRIBUTING.md#developer-certificate-of-origin). --------- Signed-off-by: Vipin Jain <[email protected]> Signed-off-by: Sunil <[email protected]>
Welcome to [Mend for GitHub.com](https://github.com/apps/mend-for-github-com) (formerly WhiteSource). This is an onboarding PR to help you understand and configure settings before Mend starts scanning your repository for security vulnerabilities. :vertical_traffic_light: Mend for GitHub.com will start scanning your repository only once you merge this Pull Request. To disable Mend for GitHub.com, simply close this Pull Request. --- ### What to Expect This PR contains a '.whitesource' configuration file which can be customized to your needs. If no changes were applied to this file, Mend for GitHub.com will use the default configuration. Before merging this PR, Make sure the [Issues tab is enabled](https://docs.mend.io/bundle/community_tools/page/enabling_the__issues__tab_for_the_github_repository.html). Once you merge this PR, Mend for GitHub.com will scan your repository and create a GitHub Issue for every vulnerability detected in your repository. If you do not want a GitHub Issue to be created for each detected vulnerability, you can edit the '.whitesource' file and set the 'minSeverityLevel' parameter to 'NONE'. If [Mend Remediate](https://docs.mend.io/bundle/integrations/page/mend_remediate_and_renovate.html) Workflow Rules are set on your repository (from the Mend 'Integrate' tab), Mend will also generate a fix Pull Request for relevant vulnerabilities. --- :question: Got questions? Check out Mend for GitHub.com [docs](https://docs.mend.io/bundle/integrations/page/mend_for_github_com.html). If you need any further assistance then you can also [request help here](https://whitesourcesoftware.force.com/CustomerCommunity/s).<!-- <WHITESOURCE>{ "installationId": "20616559"}</WHITESOURCE> --> Co-authored-by: mend-for-github-com[bot] <50673670+mend-for-github-com[bot]@users.noreply.github.com> Signed-off-by: Sunil <[email protected]>
|
@prudhvigodithi I seem to have messed up the merges here, I was planning to open up another PR or do you have any suggestions to fix it |
|
Hey @sunsrin, I usually follow these steps https://code.dblock.org/2015/08/31/getting-out-of-your-first-git-mess.html thanks to @dblock, but feel free to close and re-open a new PR. |
|
Hey @sunsrin, would you be able to fix the above errors? You can either follow these steps https://code.dblock.org/2015/08/31/getting-out-of-your-first-git-mess.html or raise a new PR and submit signed commits to clear DCO checks. |
|
@bbarani hey, yes, will do, will open a new PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update the go version to 1.22.0
Issues Resolved
Multiple security issues - CVE-2023-39323, CVE-2023-45287, CVE-2023-45285, CVE-2023-45283
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.