Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(helm): add remaining options for bootstrap #898

Merged
merged 2 commits into from
Nov 13, 2024

Conversation

iblackman
Copy link
Contributor

@iblackman iblackman commented Nov 8, 2024

Description

This PR adds the possibility to pass any option for the bootstrap component on the opensearch-cluster chart. As of now the only one that can be set using the chart is additionalConfig.

Issues Resolved

#667 . At least on the chart aspect.

Check List

  • Commits are signed per the DCO using --signoff
  • Unittest added for the new/changed functionality and all unit tests are successful
  • Customer-visible features documented
  • No linter warnings (make lint)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@swoehrl-mw
Copy link
Collaborator

Hi @iblackman.

Thank you for raising this PR.

Another option is to replace the whole block for whatever is inside the .Values.opensearchCluster.bootstrap. It would make the maintenance of the chart simpler in favor of not having explicit options.

Looking at it I think I prefer that option. Would you mind reworking your PR to that?

@iblackman
Copy link
Contributor Author

Looking at it I think I prefer that option. Would you mind reworking your PR to that?

@swoehrl-mw Done and PR description updated. Could you review it again?

@swoehrl-mw swoehrl-mw merged commit 56bd1f1 into opensearch-project:main Nov 13, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants