[OSCI][FIX] responsive basic table components #1119
Conversation
Signed-off-by: Thanh Le <[email protected]>
thanhinhchtom
requested review from
seanneumann,
AMoo-Miki,
rednaksi91,
KrooshalUX,
BSFishy,
bandinib-amzn,
ashwin-pc,
joshuarrrr,
andreymyssak and
SergeyMyssak
as code owners
Signed-off-by: Thanh Le <[email protected]>
Signed-off-by: Josh Romero <[email protected]>
|
@thanhinhchtom For UI changes like this, can you provide before/after screenshots or screencasts that demonstrate the behavior? That makes it easier for reviewers to understand the intended change and how it was tested. |
|
@joshuarrrr I already added some description of what I have done to fix the responsive and visualize it with 2 screenshots above. Is that okay? |
Yep, thanks, that's helpful! |
|
@joshuarrrr I already try to make it show 1 button in this situation, but I think the component that is currently used will make it always shows up even if I hover or not when I reduce it to 1 button. So I decided to not show anything as the recommended solution in the issue. Is it okay to do so? |
There was a problem hiding this comment.
@thanhinhchtom Thanks for the contribution - I think the code is mostly correct for what it does, but it's not quite the solution we'll want here.
| currentBreakpoint: getBreakpoint( | ||
| typeof window === 'undefined' ? -Infinity : window.innerWidth | ||
| ), |
There was a problem hiding this comment.
@thanhinhchtom I like the idea here, but I don't actually think this behavior should be dependent on the breakpoint, which is defined by the width of the browser window. Instead, what really matters is the width of the action column - we should only render the action icons on hover if there's room for them to render next to the three-dot-menu icon.
There is one complication, though, which is the fact that the table becomes responsive at small breakpoints, and the icons no longer appear on hover.
So to summarize, rather than set up a listener on the window size, you should just check the width of the action column (assuming breakpoint > s). And render however many icons (0, 1, or 2) will fit within that column width. I think you still may need a listener for cases where the overall table width changes, because column size can be set as a percentage of the table.
There was a problem hiding this comment.
@joshuarrrr So I should not use breakpoint here. Instead I should use size of the column and just fit more button if it is still enough space, right?
There was a problem hiding this comment.
yes, that's correct. Although you may also still want to have your logic skip small breakpoints, because the different layout there already handles this problem.
There was a problem hiding this comment.
Okay, I will try that and ask you later if needed?
There was a problem hiding this comment.
@joshuarrrr One more quick question. I want to clarify the requirement. So I can still use the breakpoint there if needed, but I just cannot hardcode for the different situation as what I did and I have to find the way to use the current size of the component to decide how many buttons will show up, right?
There was a problem hiding this comment.
The breakpoint usage should just be to determine whether column widths matter at all or not. But yeah the conditional logic for what and how to render should depend on the action column width. And the action column width may be itself dependent on the table/component width.
|
Wetting this to draft - @thanhinhchtom Feel free to set it back if you're able to revisit. |
Description
Fix responsive basic table components
Issues Resolved
Fix #967
I try to change the layout for the screen that is bigger than a phone and smaller than a laptop. When in this type of screen, the hover will not show up some actions anymore, instead, it just have a multiple options button.
Screenshot
Before:
After:
Check List
yarn lintyarn test-unitBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.