Fix version selector for parity with previous version #1205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matt Provost <[email protected]>
BSFishy
requested review from
AMoo-Miki,
rednaksi91,
KrooshalUX,
bandinib-amzn,
ashwin-pc,
joshuarrrr,
andreymyssak and
SergeyMyssak
as code owners
|
Does this need a changelog entry? |
|
No this does not need a changelog entry :) |
ashwin-pc
approved these changes
Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The current version selector navigates to
<url>/<version>instead of<url>/<version>/. The trailing/is necessary to navigate to the correct version. Currently, if you try navigating to a different version on https://oui.opensearch.org/1.4/, it won't change the version.Additionally, I made a change to the way the response promise is handled to properly handle case where there is an error with the fetch.
I think a change was made to the CDK to fix this as well, but I wanted to keep parity with the previous version of the version selector
Check List
yarn lintyarn test-unitBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.