[release-1.35] Bump patch version for 1.35 to 1.35.1

[creydr]

SO 1.35.0 was released. So we can bump the patch version of 1.35 to get everything prepared for a patch release.

PR to update the tag in openshift/release: openshift/release#61140

[creydr]

/test 417-test-upgrade-aws-417

[dsimansk]

/test 417-test-upgrade-aws-417

[creydr]

@pierDipi is the upgrade/downgrade failure expected on patch bumps?
I am getting a failure on the DowngradeTests:

TestServerlessUpgradePrePost/Run/Steps/DowngradeWith/DowngradeServerless
    upgrade.go:25: Serverless downgrade failed: expected ready KnativeServing at version 1.14
...
Version:1.15 
... 
context deadline exceeded

what makes sense to me, as we have

CURRENT_VERSION=1.35.1
...
PREVIOUS_VERSION=1.35.0

or is my olm.replaces (replaces: serverless-operator.v1.35.0) wrong?

Edit:
Need to update project.yaml dependencies.previous as in #3004 (97e97a3)

[creydr]

error: build error: failed to pull image: After retrying 2 times, Pull image still failed due to error: initializing source docker://image-registry.openshift-image-registry.svc:5000/ci-op-2vsfspym/pipeline@sha256:5d221cc9993d75c8a7139a05516b5214eb923b6b3f9ee2d751ddecab211cf44f: reading manifest sha256:5d221cc9993d75c8a7139a05516b5214eb923b6b3f9ee2d751ddecab211cf44f in image-registry.openshift-image-registry.svc:5000/ci-op-2vsfspym/pipeline: unknown: unable to pull manifest from quay-proxy.ci.openshift.org/openshift/ci@sha256:5d221cc9993d75c8a7139a05516b5214eb923b6b3f9ee2d751ddecab211cf44f: manifest unknown: manifest unknown
Infra issue
/retest-required

[creydr]

/retest-required

[creydr]

/retest-required

[creydr]

/retest-required

[creydr]

/test 417-test-upgrade-aws-41

[openshift-ci]

@creydr: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test 413-images

/test 413-operator-e2e-aws-413

/test 413-test-upgrade-aws-413

/test 417-aws-ovn-images

/test 417-azure-images

/test 417-gcp-images

/test 417-hypershift-images

/test 417-images

/test 417-operator-e2e-aws-417

/test 417-osd-images

/test 417-single-node-images

/test 417-test-upgrade-aws-417

/test 417-vsphere-images

/test 418-images

/test 418-operator-e2e-aws-418

/test 418-test-upgrade-aws-418

/test ocp4.17-lp-rosa-classic-images

/test ocp4.18-lp-interop-images

The following commands are available to trigger optional jobs:

/test 413-kitchensink-e2e-aws-413

/test 413-kitchensink-upgrade-aws-413

/test 413-mesh-e2e-aws-413

/test 413-mesh-upgrade-aws-413

/test 413-test-soak-aws-413

/test 413-ui-e2e-aws-413

/test 413-upstream-e2e-aws-413

/test 413-upstream-e2e-kafka-aws-413

/test 417-kitchensink-e2e-aws-417

/test 417-kitchensink-upgrade-aws-417

/test 417-mesh-e2e-aws-417

/test 417-mesh-upgrade-aws-417

/test 417-test-soak-aws-417

/test 417-ui-e2e-aws-417

/test 417-upstream-e2e-aws-417

/test 417-upstream-e2e-kafka-aws-417

/test 418-kitchensink-e2e-aws-418

/test 418-kitchensink-upgrade-aws-418

/test 418-mesh-e2e-aws-418

/test 418-mesh-upgrade-aws-418

/test 418-test-soak-aws-418

/test 418-ui-e2e-aws-418

/test 418-upstream-e2e-aws-418

/test 418-upstream-e2e-kafka-aws-418

Use /test all to run the following jobs that were automatically triggered:

pull-ci-openshift-knative-serverless-operator-release-1.35-417-images

pull-ci-openshift-knative-serverless-operator-release-1.35-417-operator-e2e-aws-417

pull-ci-openshift-knative-serverless-operator-release-1.35-417-test-upgrade-aws-417

pull-ci-openshift-knative-serverless-operator-release-1.35-417-upstream-e2e-aws-417

pull-ci-openshift-knative-serverless-operator-release-1.35-417-upstream-e2e-kafka-aws-417

In response to this:

/test 417-test-upgrade-aws-41

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[creydr]

/retest-required

[creydr]

/test 417-test-upgrade-aws-417

[creydr]

/retest

[creydr]

/retest-required

[creydr]

@pierDipi @maschmid @dsimansk can you PTAL?
/cc @pierDipi @maschmid @dsimansk

[pierDipi]

Do you know why the failed action Validate / Generated files are committed (pull_request) is deleting the override snapshot components?

[pierDipi]

/lgtm

/hold if the question is related

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: creydr, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [creydr,pierDipi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[creydr]

Do you know why the failed action Validate / Generated files are committed (pull_request) is deleting the override snapshot components?

I think this is because the override-snapshot is generated from the FBC image in quay. As we don't have yet an entry for 1.35.1 in the FBC image (which is built, after this PR merges), it can't get the components yet.

[creydr]

/unhold

[pierDipi]

@creydr isn't using latest ?

serverless-operator/hack/generate/override-snapshot.sh

Line 61 in c5fd574

latest_index_image="${registry_quay}-fbc-${max_ocp_version}/serverless-index-${so_short_version}-fbc-${max_ocp_version}:latest"

and patch doesn't matter?

serverless-operator/hack/generate/override-snapshot.sh

Lines 41 to 43 in c5fd574

	so_semversion="$(metadata.get project.version)"
	so_short_version=${so_semversion/./} # 1.36.0 -> 136.0
	so_short_version=${so_short_version%.*} # 136.0 -> 136

[creydr]

/override "Validate / Generated files are committed"

[openshift-ci]

@creydr: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

• Validate / Generated files are committed

Only the following failed contexts/checkruns were expected:

• Generated files are committed
• Update deps
• ci/prow/417-images
• ci/prow/417-operator-e2e-aws-417
• ci/prow/417-test-upgrade-aws-417
• ci/prow/417-upstream-e2e-aws-417
• ci/prow/417-upstream-e2e-kafka-aws-417
• code/snyk (Hybrid Platforms - OpenShift Serverless)
• license/snyk (Hybrid Platforms - OpenShift Serverless)
• pull-ci-openshift-knative-serverless-operator-main-417-images
• pull-ci-openshift-knative-serverless-operator-release-1.35-417-operator-e2e-aws-417
• pull-ci-openshift-knative-serverless-operator-release-1.35-417-test-upgrade-aws-417
• pull-ci-openshift-knative-serverless-operator-release-1.35-417-upstream-e2e-aws-417
• pull-ci-openshift-knative-serverless-operator-release-1.35-417-upstream-e2e-kafka-aws-417
• security/snyk (Hybrid Platforms - OpenShift Serverless)
• tide

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

/override "Validate / Generated files are committed"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[creydr]

/hold

[creydr]

@creydr isn't using latest ?

serverless-operator/hack/generate/override-snapshot.sh

Line 61 in c5fd574

latest_index_image="${registry_quay}-fbc-${max_ocp_version}/serverless-index-${so_short_version}-fbc-${max_ocp_version}:latest"

and patch doesn't matter?

serverless-operator/hack/generate/override-snapshot.sh

Lines 41 to 43 in c5fd574

	so_semversion="$(metadata.get project.version)"
	so_short_version=${so_semversion/./} # 1.36.0 -> 136.0
	so_short_version=${so_short_version%.*} # 136.0 -> 136

But to get the components from the catalog, we use the full version (so_semversion):

serverless-operator/hack/generate/override-snapshot.sh

Line 90 in c5fd574

done <<< "$(jq -r '. | select(.name == "serverless-operator.v'${so_semversion}'") | .relatedImages[].image' "${tmp_catalog_dir}/serverless-operator/catalog.json" | sort | uniq)"

$ opm migrate quay.io/redhat-user-workloads/ocp-serverless-tenant/serverless-operator-135-fbc-418/serverless-index-135-fbc-418:latest /tmp/catalog -o json
INFO[0000] rendering index "quay.io/redhat-user-workloads/ocp-serverless-tenant/serverless-operator-135-fbc-418/serverless-index-135-fbc-418:latest" as file-based catalog 
INFO[0047] wrote rendered file-based catalog to "/tmp/catalog" 

$  jq -r '. | select(.name == "serverless-operator.v1.35.0") | .relatedImages[].image' "/tmp/catalog/serverless-operator/catalog.json" | sort | uniq
registry.access.redhat.com/ubi8/nodejs-20-minimal@sha256:a2a7e399aaf09a48c28f40820da16709b62aee6f2bc703116b9345fab5830861
registry.access.redhat.com/ubi8/openjdk-21@sha256:441897a1f691c7d4b3a67bb3e0fea83e18352214264cb383fd057bbbd5ed863c
registry.access.redhat.com/ubi8/python-39@sha256:27e795fd6b1b77de70d1dc73a65e4c790650748a9cfda138fdbd194b3d6eea3d
...

$ jq -r '. | select(.name == "serverless-operator.v1.35.1") | .relatedImages[].image' "/tmp/catalog/serverless-operator/catalog.json" | sort | uniq
<empty>

Does this make sense?

[creydr]

/unhold

[creydr]

/override "Generated files are committed"

[openshift-ci]

@creydr: Overrode contexts on behalf of creydr: Generated files are committed

In response to this:

/override "Generated files are committed"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.