Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAIN] Remove "DELETE" from the Serving validating webhook #1169

Conversation

skonto
Copy link

@skonto skonto commented Feb 5, 2025

What this PR does / why we need it:

Which issue(s) this PR fixes:

JIRA:

Does this PR needs for other branches:

Does this PR (patch) needs to update/drop in the future?:

JIRA:

@openshift-ci openshift-ci bot requested review from dsimansk and mvinkler February 5, 2025 15:41
@openshift-ci openshift-ci bot added the approved label Feb 5, 2025
@skonto skonto removed the request for review from mvinkler February 5, 2025 15:44
@dsimansk
Copy link

dsimansk commented Feb 6, 2025

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm label Feb 6, 2025
Copy link

openshift-ci bot commented Feb 6, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dsimansk, skonto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 2c17c3c into openshift-knative:main Feb 6, 2025
5 checks passed
@openshift-cherrypick-robot

@skonto: cannot checkout release-vX.Y: error checking out "release-vX.Y": exit status 1 error: pathspec 'release-vX.Y' did not match any file(s) known to git

In response to this:

What this PR does / why we need it:

Which issue(s) this PR fixes:

JIRA:

Does this PR needs for other branches:

Does this PR (patch) needs to update/drop in the future?:

JIRA:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants