[RELEASE-1.11] Backport of Support GRPC probes #582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add gRPC probe * Modify unit test * Modify unit test * Set default to grpcprobe's service field * Use knative pkg for ptr operation * Use config's KubeMajor & KubeMinor instead of k8s native version pkg * Wrap error in GRPCProbe * Add comment to explain why use dialer_others.go * Run update scripts * Add probe test * Add test in readiness/probe_test.go * update deps * Ignore readinessProbe when it's gRPC * Fix test to use empemeral port * Resolve govet lint error * Use errors.Is to compare * Also use ephemeral port for handler test * drop unneccesary else block (cherry picked from commit d02702e)
|
/unhold /assign @skonto |
skonto
reviewed
Jan 10, 2024
|
/lgtm /hold do we need any e2e test? |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ReToCode, skonto The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/unhold we will deal with e2e tests separately. |
|
/unhold |
openshift-merge-bot
bot
merged commit d1ff617
into
openshift-knative:release-v1.11
10 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes:
JIRA: https://issues.redhat.com/browse/SRVKS-1185
Does this PR needs for other branches:
No, it is already included in 1.12
Does this PR (patch) needs to update/drop in the future?:
No
/hold testing on OCP