Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RELEASE-1.11] Add defaulting for all GRPC probe types #586

Merged
merged 2 commits into from
Jan 22, 2024
Merged

[RELEASE-1.11] Add defaulting for all GRPC probe types #586

merged 2 commits into from
Jan 22, 2024

Conversation

ReToCode
Copy link

@ReToCode
Add defaulting for all GRPC probe types (knative#14773)
c8dd660 
* Add defaulting for all GRPC probe types

* Add an E2E readiness test with GRPC probes

* Rename function

(cherry picked from commit 7feb050)
@openshift-ci openshift-ci bot requested review from alanfx and rhuss January 12, 2024 06:48
@skonto
Copy link

skonto commented Jan 18, 2024

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm label Jan 18, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jan 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ReToCode, skonto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@skonto
Copy link

skonto commented Jan 18, 2024

/unhold

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD f2b8975 and 2 for PR HEAD 6362b80 in total

@ReToCode
Copy link
Author

/retest

@skonto
Copy link

skonto commented Jan 19, 2024 •
edited
Loading

Warning Failed 4m48s (x5 over 6m6s) kubelet Error: ImagePullBackOff
Normal Pulling 4m37s (x4 over 6m7s) kubelet Pulling image "image-registry.openshift-image-registry.svc:5000/openshift-marketplace/serverless-knative-operator"
Warning Failed 4m37s (x4 over 6m7s) kubelet Failed to pull image "image-registry.openshift-image-registry.svc:5000/openshift-marketplace/serverless-knative-operator": rpc error: code = Unknown desc = reading manifest latest in image-registry.openshift-image-registry.svc:5000/openshift-marketplace/serverless-knative-operator: manifest unknown: manifest unknown
Normal BackOff 69s (x20 over 6m6s) kubelet Back-off pulling image "image-registry.openshift-image-registry.svc:5000/openshift-marketplace/serverless-knative-operator"

@skonto
Copy link

skonto commented Jan 19, 2024

/test 411-test-e2e-aws-ocp-411

@ReToCode
Copy link
Author

/retest-required

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 94715ac and 1 for PR HEAD 6362b80 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 1cac6d0 and 0 for PR HEAD 6362b80 in total

@openshift-merge-bot openshift-merge-bot bot merged commit b333c05 into openshift-knative:release-v1.11 Jan 22, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alanfx alanfx Awaiting requested review from alanfx

@rhuss rhuss Awaiting requested review from rhuss

Assignees

@skonto skonto

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ReToCode @skonto @openshift-ci-robot