Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RELEASE-1.11] Move to Golang version 1.21 (#546) #592

Merged

Conversation

skonto
Copy link

@skonto skonto commented Jan 17, 2024

Proposed Changes

* move to 1.21

* fix actions

* update perf tests patch

* fix multi-arch
@skonto skonto requested a review from ReToCode January 17, 2024 18:23
@openshift-ci openshift-ci bot requested review from alanfx and mvinkler January 17, 2024 18:23
@skonto skonto removed request for alanfx and mvinkler January 17, 2024 18:23
@skonto skonto removed their assignment Jan 17, 2024
@skonto
Copy link
Author

skonto commented Jan 17, 2024

/retest

Copy link

@ReToCode ReToCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
/hold let's wait until we know that we can productize it with go 1.21

Copy link

openshift-ci bot commented Jan 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ReToCode, skonto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@skonto
Copy link
Author

skonto commented Jan 18, 2024

@ReToCode it seems we are ok with the productization https://redhat-internal.slack.com/archives/CF5ANN61F/p1705515999236559

@ReToCode
Copy link

👍
/unhold

@openshift-merge-bot openshift-merge-bot bot merged commit f2b8975 into openshift-knative:release-v1.11 Jan 18, 2024
10 checks passed
@ReToCode
Copy link

/cherry-pick release-v1.12

@openshift-cherrypick-robot

@ReToCode: #592 failed to apply on top of branch "release-v1.12":

Applying: Move to Golang version 1.21 (#546)
Using index info to reconstruct a base tree...
M	openshift/performance/patches/perf.patch
Falling back to patching base and 3-way merge...
Auto-merging openshift/performance/patches/perf.patch
CONFLICT (content): Merge conflict in openshift/performance/patches/perf.patch
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Move to Golang version 1.21 (#546)
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-v1.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ReToCode pushed a commit that referenced this pull request Jan 23, 2024
* move to 1.21

* fix actions

* update perf tests patch

* fix multi-arch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants