-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RELEASE-1.11] Move to Golang version 1.21 (#546) #592
[RELEASE-1.11] Move to Golang version 1.21 (#546) #592
Conversation
* move to 1.21 * fix actions * update perf tests patch * fix multi-arch
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
/hold let's wait until we know that we can productize it with go 1.21
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ReToCode, skonto The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@ReToCode it seems we are ok with the productization https://redhat-internal.slack.com/archives/CF5ANN61F/p1705515999236559 |
👍 |
f2b8975
into
openshift-knative:release-v1.11
/cherry-pick release-v1.12 |
@ReToCode: #592 failed to apply on top of branch "release-v1.12":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Proposed Changes