Update NodeSwap with owner and doc blurb. #2053
Conversation
|
Hello @rphillips! Some important instructions when contributing to openshift/api: |
openshift-ci
bot
added
the
size/XS
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: rphillips The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@rphillips: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
| @@ -85,9 +85,11 @@ var ( | |||
| enableIn(configv1.Default, configv1.DevPreviewNoUpgrade, configv1.TechPreviewNoUpgrade). | |||
| mustRegister() | |||
|
|
|||
| // OpenShift and Node Team will keep this turned off until evictions and | |||
| // disk provisioning are fixed even though upstream will take this GA. | |||
There was a problem hiding this comment.
At a mechanical level, when a feature is GA, kube removes the gating logic from code. Will we enforce this by preventing certain kubelet flags from being set?
There was a problem hiding this comment.
yes we'll turn it off by setting the KubeletConfiguration NoSwap value, and also keeping the fail-swap-on flag on. CNV will be able to turn on LimitedSwap and turn off fail-swap-on
There was a problem hiding this comment.
Yes, there will be something to block it, but the details have not been ironed out yet.
There was a problem hiding this comment.
we have plans to provide API level gating of that in MCO KubeletConfig controller (which hopefully will detect the presence of CNV to toggle the gating off, details still need to be figured out)
Updated with new owner and doc blurb.