CORS-3842: Add API Updates for GCP Custom API Endpoints #2150
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@barbacbd: This pull request references CORS-3842 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Hello @barbacbd! Some important instructions when contributing to openshift/api: |
|
/cc @patrickdillon |
openshift-ci
bot
added
the
size/XXL
|
/cc @JoelSpeed |
|
/retest |
|
/retest-required |
|
/retest |
There was a problem hiding this comment.
Spotted a few more things. It would also be beneficial to add tests where possible to ensure any validations you are putting in place are acting as expected. https://github.com/openshift/api?tab=readme-ov-file#defining-api-validation-tests should be helpful in getting you started on the right track for adding any necessary tests.
There was a problem hiding this comment.
A few more things. Other than these I think this is shaping up well. After this round of comments is addressed I'll rope @JoelSpeed in to do a pass since he is the one with approval authority.
...tion/v1/tests/controllerconfigs.machineconfiguration.openshift.io/GCPCustomAPIEndpoints.yaml
Outdated
Show resolved
Hide resolved
barbacbd
force-pushed
the
CORS-3842
branch
2 times, most recently
from
04681c3 to
ea88b6c
Compare
There was a problem hiding this comment.
Changes look good to me.
Tagging in @JoelSpeed for a review.
|
/retest |
openshift-ci
bot
added
lgtm
|
/test e2e-aws-ovn-hypershift |
|
/test e2e-aws-serial-techpreview |
openshift-merge-robot
added
the
needs-rebase
** Add the Tech preview and No upgrade tags for the new feature GCP API Custom Endpoints. ** Add the ServiceEndpoint Structure that includes the api name and endpoint. ** Add the Service Endpoints to the GCP Spec and Status structs.
openshift-merge-robot
removed
the
needs-rebase
|
/lgtm No new errors in the verify, picking up new partial/unmerged CRDs |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: barbacbd, everettraven, JoelSpeed The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@JoelSpeed: Overrode contexts on behalf of JoelSpeed: ci/prow/verify-crd-schema In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/retest-required |
|
/override ci/prow/verify-crd-schema |
|
@JoelSpeed: Overrode contexts on behalf of JoelSpeed: ci/prow/verify-crd-schema In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@barbacbd: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
openshift-merge-bot
bot
merged commit ead8ee7
into
openshift:master
|
[ART PR BUILD NOTIFIER] Distgit: ose-cluster-config-api |
…API Endpoints **Vendor updates: Add the api changes from openshift/api#2150
** Add the Tech preview and No upgrade tags for the new feature GCP API Custom Endpoints.
** Add the ServiceEndpoint Structure that includes the api name and endpoint.
** Add the Service Endpoints to the GCP Spec and Status structs.