Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SPLAT-2000: Add configuration for vSphere multi disk thinProvisioned #2154

Merged
merged 1 commit into from
Feb 18, 2025
Merged

SPLAT-2000: Add configuration for vSphere multi disk thinProvisioned #2154

merged 1 commit into from
Feb 18, 2025

Conversation

vr4manta
Copy link
Contributor

@vr4manta vr4manta commented Jan 16, 2025 •
edited
Loading

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 16, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 16, 2025 •
edited by openshift-ci bot
Loading

@vr4manta: This pull request references SPLAT-2000 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

SPLAT-2000

Changes

  • Added thinProvisioned to VSphereDisk
  • Fixed max size for data disk

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 16, 2025

Hello @vr4manta! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 16, 2025
@openshift-ci openshift-ci bot requested review from bparees and mandre January 16, 2025 15:47
@vr4manta vr4manta force-pushed the vsphere_multi_disk_provisioning branch from 34c1b68 to d6b81cd Compare January 16, 2025 20:16
@vr4manta
Copy link
Contributor Author

/hold

@openshift-ci openshift-ci bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 16, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 23, 2025 •
edited by openshift-ci bot
Loading

@vr4manta: This pull request references SPLAT-2000 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

SPLAT-2000

Changes

  • Added thinProvisioned to VSphereDisk

Notes

  • Working with upstream CAPV to add similar behavior to prevent gap

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 23, 2025
@vr4manta vr4manta force-pushed the vsphere_multi_disk_provisioning branch from f1f4494 to a2460ae Compare February 4, 2025 20:17
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 4, 2025
@openshift-ci openshift-ci bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 4, 2025
@vr4manta
Copy link
Contributor Author

vr4manta commented Feb 4, 2025

/unhold
Removed hold. Upstream changes in CAPV are now merged and making MAPI match.

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 4, 2025
@vr4manta vr4manta mentioned this pull request Feb 4, 2025
Merged
@vr4manta vr4manta force-pushed the vsphere_multi_disk_provisioning branch from a2460ae to 2eac068 Compare February 4, 2025 20:51
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 4, 2025 •
edited by openshift-ci bot
Loading

@vr4manta: This pull request references SPLAT-2000 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

SPLAT-2000

Changes

  • Added thinProvisioned to VSphereDisk

Blocks

Notes

  • Working with upstream CAPV to add similar behavior to prevent gap

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@vr4manta
Copy link
Contributor Author

vr4manta commented Feb 5, 2025

/retest-required

@vr4manta vr4manta force-pushed the vsphere_multi_disk_provisioning branch from 2eac068 to 21077c9 Compare February 5, 2025 18:01
@vr4manta vr4manta mentioned this pull request Feb 5, 2025
Open
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 5, 2025 •
edited by openshift-ci bot
Loading

@vr4manta: This pull request references SPLAT-2000 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

SPLAT-2000

Changes

  • Added thinProvisioned to VSphereDisk

Blocks

Notes

  • Working with upstream CAPV to add similar behavior to prevent gap

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 5, 2025 •
edited by openshift-ci bot
Loading

@vr4manta: This pull request references SPLAT-2000 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

SPLAT-2000

Changes

  • Added thinProvisioned to VSphereDisk

Blocks

Notes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@vr4manta
Copy link
Contributor Author

vr4manta commented Feb 5, 2025

/assign @JoelSpeed
Ready for review. Thanks!

@vr4manta vr4manta force-pushed the vsphere_multi_disk_provisioning branch from 21077c9 to 4f66051 Compare February 11, 2025 15:32
@openshift-ci openshift-ci bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 11, 2025
@vr4manta vr4manta force-pushed the vsphere_multi_disk_provisioning branch from 4f66051 to d8dbadc Compare February 12, 2025 18:09
everettraven
everettraven reviewed Feb 12, 2025
View reviewed changes
Copy link
Contributor

@everettraven everettraven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've only got one more comment, but overall this looks pretty good.

I would like to see both my outstanding comments be addressed prior to getting my stamp of approval and tagging in Joel for a pass

@vr4manta vr4manta force-pushed the vsphere_multi_disk_provisioning branch from d8dbadc to 66e2cdc Compare February 12, 2025 19:37
@vr4manta
Copy link
Contributor Author

@JoelSpeed / @everettraven , ready for next round of review. Thanks!

everettraven
everettraven reviewed Feb 13, 2025
View reviewed changes
Copy link
Contributor

@everettraven everettraven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than a concern on some terminology I think this looks good.

I'll go ahead and pull @JoelSpeed in for a pass. If Joel thinks it looks good and doesn't share the same concerns I do for the terminology I won't block this.

@vr4manta vr4manta force-pushed the vsphere_multi_disk_provisioning branch from 66e2cdc to 97c4008 Compare February 13, 2025 19:07
everettraven
everettraven approved these changes Feb 13, 2025
View reviewed changes
Copy link
Contributor

@everettraven everettraven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM. Officially tagging in @JoelSpeed for a pass.

@jcpowermac
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 13, 2025
@JoelSpeed
Copy link
Contributor

@vr4manta Does this field already exist in the upstream CAPI provider? And do you have a PR to MAO to implement the appropriate validation of the schema?

@vr4manta
Copy link
Contributor Author

@vr4manta Does this field already exist in the upstream CAPI provider? And do you have a PR to MAO to implement the appropriate validation of the schema?

Yes, I've made the changes upstream first. The link to that PR is in the top comment along w/ the dependent PRs for implementing these changes. I have reconciler, but I'll look more into the webhook to make sure validation is done.

@JoelSpeed
Copy link
Contributor

/lgtm

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 17, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: everettraven, jcpowermac, JoelSpeed, vr4manta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 17, 2025
@vr4manta
Copy link
Contributor Author

/label acknowledge-critical-fixes-only

@openshift-ci openshift-ci bot added the acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. label Feb 18, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 18, 2025

@vr4manta: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 8b82294 into openshift:master Feb 18, 2025
12 checks passed
@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

Distgit: ose-cluster-config-api
This PR has been included in build ose-cluster-config-api-container-v4.19.0-202502181507.p0.g8b82294.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoelSpeed JoelSpeed JoelSpeed left review comments

@everettraven everettraven everettraven approved these changes

@bparees bparees Awaiting requested review from bparees

@mandre mandre Awaiting requested review from mandre

Assignees

@jcpowermac jcpowermac

@JoelSpeed JoelSpeed

@everettraven everettraven

Labels
acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@vr4manta @openshift-ci-robot @jcpowermac @JoelSpeed @openshift-bot @everettraven @openshift-merge-robot