Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-49298: Enable group snapshots as default feature #2169

Open
wants to merge 1 commit into
base: release-4.18
Choose a base branch
from

Conversation

gnufied
Copy link
Member

@gnufied gnufied commented Jan 23, 2025

No description provided.

Copy link
Contributor

openshift-ci bot commented Jan 23, 2025

Hello @gnufied! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 23, 2025
@openshift-ci openshift-ci bot requested review from bparees and sjenning January 23, 2025 22:05
Copy link
Contributor

openshift-ci bot commented Jan 23, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: gnufied
Once this PR has been reviewed and has the lgtm label, please assign spadgett for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

openshift-ci bot commented Jan 24, 2025

@gnufied: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/verify 30b40bc link true /test verify
ci/prow/e2e-gcp 30b40bc link false /test e2e-gcp

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@gnufied gnufied changed the title Enable group snapshots as default feature OCPBUGS-49298: Enable group snapshots as default feature Jan 24, 2025
@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jan 24, 2025
@openshift-ci-robot
Copy link

@gnufied: This pull request references Jira Issue OCPBUGS-49298, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
  • expected Jira Issue OCPBUGS-49298 to depend on a bug targeting a version in 4.19.0 and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@gnufied
Copy link
Member Author

gnufied commented Jan 24, 2025

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jan 24, 2025
@openshift-ci-robot
Copy link

@gnufied: This pull request references Jira Issue OCPBUGS-49298, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.18.0) matches configured target version for branch (4.18.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note text is set and does not match the template
  • dependent bug Jira Issue OCPBUGS-49297 is in the state MODIFIED, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Jira Issue OCPBUGS-49297 targets the "4.19.0" version, which is one of the valid target versions: 4.19.0
  • bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@gnufied
Copy link
Member Author

gnufied commented Feb 3, 2025

/payload-job periodic-ci-openshift-cluster-storage-operator-release-4.18-e2e-aws-group-snapshot-tp

Copy link
Contributor

openshift-ci bot commented Feb 3, 2025

@gnufied: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-cluster-storage-operator-release-4.18-e2e-aws-group-snapshot-tp

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/61a21280-e24f-11ef-8223-010a9de9c647-0

@gnufied
Copy link
Member Author

gnufied commented Feb 3, 2025

/payload-job periodic-ci-openshift-cluster-storage-operator-release-4.18-e2e-aws-group-snapshot-tp 3

Copy link
Contributor

openshift-ci bot commented Feb 3, 2025

@gnufied: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-cluster-storage-operator-release-4.18-e2e-aws-group-snapshot-tp

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/6983b7c0-e26c-11ef-8680-5a2e163ee0dc-0

@gnufied
Copy link
Member Author

gnufied commented Feb 4, 2025

/payload-job periodic-ci-openshift-cluster-storage-operator-release-4.18-e2e-aws-group-snapshot-tp 3

Copy link
Contributor

openshift-ci bot commented Feb 4, 2025

@gnufied: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-cluster-storage-operator-release-4.18-e2e-aws-group-snapshot-tp

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/21a50ef0-e293-11ef-8012-99fce7fd9059-0

@gnufied
Copy link
Member Author

gnufied commented Feb 4, 2025

/payload-job periodic-ci-openshift-cluster-storage-operator-release-4.18-e2e-aws-group-snapshot-tp

Copy link
Contributor

openshift-ci bot commented Feb 4, 2025

@gnufied: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-cluster-storage-operator-release-4.18-e2e-aws-group-snapshot-tp

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/d09428c0-e30f-11ef-8864-f47825188f60-0

@gnufied
Copy link
Member Author

gnufied commented Feb 5, 2025

/payload-job periodic-ci-openshift-cluster-storage-operator-release-4.18-e2e-aws-group-snapshot-tp

Copy link
Contributor

openshift-ci bot commented Feb 5, 2025

@gnufied: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-cluster-storage-operator-release-4.18-e2e-aws-group-snapshot-tp

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/4a6a4640-e3d6-11ef-9e0d-9a421d24b840-0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants