-
Notifications
You must be signed in to change notification settings - Fork 525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
STOR-2141: add MaxAllowedBlockVolumesPerNode field to VSphereCSIDriverConfigSpec #2190
base: master
Are you sure you want to change the base?
Conversation
@RomanBednar: This pull request references STOR-2141 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.19.0" version, but no target version was set. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Hello @RomanBednar! Some important instructions when contributing to openshift/api: |
d631664
to
92871d0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good to me. Tagging in @JoelSpeed for a round of review/approval.
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: everettraven, RomanBednar The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
92871d0
to
d361345
Compare
...lustercsidrivers.operator.openshift.io/VSphereConfigurableMaxAllowedBlockVolumesPerNode.yaml
Outdated
Show resolved
Hide resolved
The error in verify-crd-schema job does not sound related to this PR: |
d361345
to
ec59951
Compare
46b10e0
to
78a4793
Compare
78a4793
to
17d87dc
Compare
@RomanBednar: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
ping @JoelSpeed - to review the new version. |
No description provided.