Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STOR-2141: add MaxAllowedBlockVolumesPerNode field to VSphereCSIDriverConfigSpec #2190

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

RomanBednar
Copy link
Contributor

No description provided.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 3, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 3, 2025

@RomanBednar: This pull request references STOR-2141 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.19.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Contributor

openshift-ci bot commented Feb 3, 2025

Hello @RomanBednar! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@openshift-ci openshift-ci bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Feb 3, 2025
@openshift-ci openshift-ci bot requested review from deads2k and sjenning February 3, 2025 17:02
operator/v1/types_csi_cluster_driver.go Outdated Show resolved Hide resolved
operator/v1/types_csi_cluster_driver.go Outdated Show resolved Hide resolved
operator/v1/types_csi_cluster_driver.go Outdated Show resolved Hide resolved
operator/v1/types_csi_cluster_driver.go Show resolved Hide resolved
operator/v1/types_csi_cluster_driver.go Outdated Show resolved Hide resolved
operator/v1/types_csi_cluster_driver.go Outdated Show resolved Hide resolved
Copy link

@everettraven everettraven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me. Tagging in @JoelSpeed for a round of review/approval.

Copy link
Contributor

openshift-ci bot commented Feb 5, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: everettraven, RomanBednar
Once this PR has been reviewed and has the lgtm label, please assign deads2k for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@RomanBednar
Copy link
Contributor Author

The error in verify-crd-schema job does not sound related to this PR: ConditionsMustHaveProperSSATags: crd/clustercsidrivers.operator.openshift.io version/v1 field/^.status.condition must define valid condition properties: observedGeneration attribute is missing - is that a good candidate for /override?

operator/v1/types_csi_cluster_driver.go Outdated Show resolved Hide resolved
operator/v1/types_csi_cluster_driver.go Outdated Show resolved Hide resolved
operator/v1/types_csi_cluster_driver.go Outdated Show resolved Hide resolved
Copy link
Contributor

openshift-ci bot commented Feb 12, 2025

@RomanBednar: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-serial-techpreview 17d87dc link true /test e2e-aws-serial-techpreview
ci/prow/minor-e2e-upgrade-minor 17d87dc link true /test minor-e2e-upgrade-minor
ci/prow/okd-scos-e2e-aws-ovn 17d87dc link false /test okd-scos-e2e-aws-ovn
ci/prow/e2e-aws-ovn-hypershift 17d87dc link true /test e2e-aws-ovn-hypershift
ci/prow/verify-crd-schema 17d87dc link true /test verify-crd-schema

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@RomanBednar
Copy link
Contributor Author

ping @JoelSpeed - to review the new version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants