Promote OnClusterBuild featuregate to default

[yuqi-zhang]

Final step to GA On Cluster Layering, after
openshift/machine-config-operator#4756 and #2134

See also updated enhancement: openshift/enhancements#1515

[openshift-ci]

Hello @yuqi-zhang! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: yuqi-zhang
Once this PR has been reviewed and has the lgtm label, please assign joelspeed for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[yuqi-zhang]

/hold

Currently for testing

[JoelSpeed]

Given the absence of automated testing reporting into component readiness, there is a want to make an exception for this feature and promote within 4.19 based on QE testing alone

Could we please get a write up on this PR detailing the existing testing that QE have been completing, with links to historical pass rates where available

I would also appreciate if we can link out to any trackers for the future automated regression testing that's in the pipeline

[JoelSpeed]

Verify failure in schema checker is an issue with the alpha API, we will override that issue

/test e2e-aws-ovn-hypershift
/test minor-e2e-upgrade-minor

[JoelSpeed]

@yuqi-zhang @cheesesashimi The failures in the minor upgrade look like they are legitimate, can you please investigate?

[yuqi-zhang]

Rebased on master just in case. It looks like in the failed upgrade, the MCO hasn't started upgrade yet (?) and the operator logs are failing on:

E0320 14:53:14.386733       1 reflector.go:158] "Unhandled Error" err="github.com/openshift/machine-config-operator/pkg/operator/operator.go:390: Failed to watch *v1alpha1.MachineOSConfig: failed to list *v1alpha1.MachineOSConfig: the server could not find the requested resource (get machineosconfigs.machineconfiguration.openshift.io)"

checking if that was caused by outdated CRDs.

The kube-rbac-proxy failures should also be old, since the pods should have the proper SCC labels now

[openshift-ci]

@yuqi-zhang: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws-serial-techpreview	c939ea4	link	true	/test e2e-aws-serial-techpreview
ci/prow/e2e-aws-ovn-techpreview	c939ea4	link	true	/test e2e-aws-ovn-techpreview
ci/prow/verify-feature-promotion	c939ea4	link	true	/test verify-feature-promotion
ci/prow/verify-crd-schema	c939ea4	link	true	/test verify-crd-schema
ci/prow/minor-e2e-upgrade-minor	c939ea4	link	true	/test minor-e2e-upgrade-minor
ci/prow/e2e-azure	c939ea4	link	false	/test e2e-azure
ci/prow/e2e-aws-ovn-hypershift	c939ea4	link	true	/test e2e-aws-ovn-hypershift

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[JoelSpeed]

/retest