Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] CNTRLPLANE-5: Add CBOR feature gate #2235

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

bertinatto
Copy link
Member

@bertinatto bertinatto commented Mar 13, 2025

No description provided.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 13, 2025
Copy link
Contributor

openshift-ci bot commented Mar 13, 2025

Hello @bertinatto! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 13, 2025
@openshift-ci openshift-ci bot requested review from bparees and knobunc March 13, 2025 21:40
Copy link
Contributor

openshift-ci bot commented Mar 14, 2025

@bertinatto: This PR was included in a payload test run from openshift/origin#29601
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-ci-4.19-e2e-aws-ovn-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/fb18fb60-00e3-11f0-954e-e5104ec1769c-0

@bertinatto bertinatto changed the title WIP: Add CBOR feature gate [WIP] CNTRLPLANE-5: Add CBOR feature gate Mar 14, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 14, 2025

@bertinatto: This pull request references CNTRLPLANE-5 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 14, 2025
Copy link
Contributor

openshift-ci bot commented Mar 14, 2025

@bertinatto: This PR was included in a payload test run from openshift/origin#29601
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-ci-4.19-e2e-aws-ovn-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/daacde90-0102-11f0-9446-602cd77896e3-0

@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 17, 2025

@bertinatto: This pull request references CNTRLPLANE-5 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

CBOR serving and storage in apiserver should be TechPreview in 4.19, so we need to adjust our test to accept that type of storage in etcd.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@bertinatto bertinatto force-pushed the add-cbor-feature-gate branch from 28c2919 to 9df67b9 Compare March 17, 2025 20:37
@openshift-ci openshift-ci bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 17, 2025
Copy link
Contributor

openshift-ci bot commented Mar 17, 2025

@bertinatto: This PR was included in a payload test run from openshift/cluster-kube-controller-manager-operator#836
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-nightly-4.19-e2e-vsphere-ovn-techpreview-serial

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/8543cf00-0386-11f0-88e2-18ded3b7324c-0

@bertinatto
Copy link
Member Author

/test all

Copy link
Contributor

openshift-ci bot commented Mar 18, 2025

@bertinatto: No presubmit jobs available for openshift/api@master

In response to this:

/test all

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Contributor

openshift-ci bot commented Mar 18, 2025

@bertinatto: This PR was included in a payload test run from openshift/cluster-kube-controller-manager-operator#836
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-nightly-4.19-e2e-vsphere-ovn-techpreview-serial

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/586fa690-03ed-11f0-84e0-c6a332c9fc36-0

@bertinatto
Copy link
Member Author

/test all

Copy link
Contributor

openshift-ci bot commented Mar 18, 2025

@bertinatto: No presubmit jobs available for openshift/api@master

In response to this:

/test all

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Contributor

openshift-ci bot commented Mar 18, 2025

@bertinatto: This PR was included in a payload test run from openshift/cluster-kube-controller-manager-operator#836
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-nightly-4.19-e2e-vsphere-ovn-techpreview-serial

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/d6bd4c40-0420-11f0-8fa0-4b4731e3323c-0

Copy link
Contributor

openshift-ci bot commented Mar 18, 2025

@bertinatto: This PR was included in a payload test run from openshift/cluster-kube-controller-manager-operator#836
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-nightly-4.19-e2e-vsphere-ovn-techpreview-serial

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/5f2a0c40-043e-11f0-811a-c450532f4e61-0

@bertinatto bertinatto force-pushed the add-cbor-feature-gate branch from 9df67b9 to 006bc17 Compare March 19, 2025 13:12
@openshift-ci openshift-ci bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 19, 2025
@bertinatto
Copy link
Member Author

/retest

@bertinatto bertinatto force-pushed the add-cbor-feature-gate branch from 006bc17 to 1b0f268 Compare March 20, 2025 20:05
Copy link
Contributor

openshift-ci bot commented Mar 20, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bertinatto
Once this PR has been reviewed and has the lgtm label, please assign joelspeed for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@bertinatto bertinatto force-pushed the add-cbor-feature-gate branch from 1b0f268 to 3593cda Compare March 20, 2025 21:22
@openshift-ci openshift-ci bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 20, 2025
@bertinatto
Copy link
Member Author

/retest

3 similar comments
@bertinatto
Copy link
Member Author

/retest

@bertinatto
Copy link
Member Author

/retest

@bertinatto
Copy link
Member Author

/retest

Copy link
Contributor

openshift-ci bot commented Mar 24, 2025

@bertinatto: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-serial-techpreview 3593cda link true /test e2e-aws-serial-techpreview

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants