SPLAT-2079: Removed VSphereControlPlaneMachineSet feature gate

[vr4manta]

SPLAT-2079

Changes

• Removed VSphereControlPlaneMachineSet feature gate
• Fixed CRD to have config available as default

Dependencies

• SPLAT-2079: Removed VSphereControlPlaneMachineset feature gate cluster-control-plane-machine-set-operator#354

[openshift-ci-robot]

@vr4manta: This pull request references SPLAT-2079 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

SPLAT-2079

Changes

• Removed VSphereControlPlaneMachineSet feature gate
• Fixed CRD to have config available as default

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[openshift-ci]

Hello @vr4manta! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

[openshift-ci-robot]

@vr4manta: This pull request references SPLAT-2079 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

SPLAT-2079

Changes

• Removed VSphereControlPlaneMachineSet feature gate
• Fixed CRD to have config available as default

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@vr4manta: This pull request references SPLAT-2079 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

SPLAT-2079

Changes

• Removed VSphereControlPlaneMachineSet feature gate
• Fixed CRD to have config available as default

Dependencies

• SPLAT-2079: Removed VSphereControlPlaneMachineset feature gate cluster-control-plane-machine-set-operator#354

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

@vr4manta: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws-serial	eb58fd1	link	true	/test e2e-aws-serial
ci/prow/e2e-aws-serial-techpreview	eb58fd1	link	true	/test e2e-aws-serial-techpreview

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[JoelSpeed]

/payload-job periodic-ci-openshift-release-master-nightly-4.19-e2e-vsphere-ovn

To verify that vSphere clusters will still function/boot without issue

[openshift-ci]

@JoelSpeed: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

• periodic-ci-openshift-release-master-nightly-4.19-e2e-vsphere-ovn

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/398f2230-1146-11f0-8097-56c814f65c85-0

[JoelSpeed]

This feature has been enabled for more than a year, it's safe to remove now

/lgtm

/hold we need to make sure the CPMS is happy in the payload job I triggered before we allow this to merge

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed, vr4manta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [JoelSpeed]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[vr4manta]

@JoelSpeed , the payload-test has completed and passed. Are you ok with removing the hold?

[JoelSpeed]

/hold cancel