Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MCO-1002: Add a flag to allow irreconcilable configs #2244

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pablintino
Copy link

The flag will tell the operator to skip the irreconcilable fields validation and let the user update/patch conflictive MCs in the cluster at his own risk. This feature is specially thought to allow users to add new nodes in a long standing cluster with newer configuration.

The flag will tell the operator to skip the irreconcilable fields
validation and let the user update/patch conflictive MCs in the cluster
at his own risk. This feature is specially thought to allow users to add
new nodes in a long standing cluster with newer configuration.
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 20, 2025

@pablintino: This pull request references MCO-1002 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.19.0" version, but no target version was set.

In response to this:

The flag will tell the operator to skip the irreconcilable fields validation and let the user update/patch conflictive MCs in the cluster at his own risk. This feature is specially thought to allow users to add new nodes in a long standing cluster with newer configuration.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 20, 2025
Copy link
Contributor

openshift-ci bot commented Mar 20, 2025

Hello @pablintino! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 20, 2025
Copy link
Contributor

openshift-ci bot commented Mar 20, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: pablintino
Once this PR has been reviewed and has the lgtm label, please assign deads2k for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

// ignoreIrreconcilableConfig tells the operator to ignore irreconciliable configuration changes
// in already existing nodes. New nodes joining the cluster will see the newest configuration.
// +optional
IgnoreIrreconciliableConfig bool `json:"ignoreIrreconcilableConfig"`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not use a boolean here. Things generally start as booleans but can end up progressing to need more than a true/false option. Make this an enum instead so that you can add additional options in the future if needed. Using a boolean makes it so you cannot change this to support other options in the future.

For more information on why we encourage enums over booleans see: https://github.com/openshift/enhancements/blob/master/dev-guide/api-conventions.md#do-not-use-boolean-fields

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additionally, this is being added to a v1 API - should this be feature-gated?

Copy link
Contributor

openshift-ci bot commented Mar 20, 2025

@pablintino: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-azure b99c553 link false /test e2e-azure
ci/prow/e2e-aws-serial-techpreview b99c553 link true /test e2e-aws-serial-techpreview
ci/prow/verify-crd-schema b99c553 link true /test verify-crd-schema
ci/prow/lint b99c553 link true /test lint

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants