WIP: Replace readyz sidecar container with etcds own probes #1321
Conversation
openshift-ci
bot
added
the
do-not-merge/work-in-progress
jubittajohn
changed the title
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jubittajohn The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: jubittajohn <[email protected]>
jubittajohn
force-pushed
the
remove-readyz-sidecar-container
branch
from
9e5ac8c
to
2cf5c88
Compare
| port: 9980 | ||
| path: readyz | ||
| port: 2379 | ||
| path: readyz?exclude=data_corruption&exclude=linearized_read | ||
| scheme: HTTPS |
There was a problem hiding this comment.
I think it's failing on:
{"level":"warn","ts":"2024-08-20T03:55:49.588638Z","caller":"embed/config_logging.go:169","msg":"rejected connection","remote-addr":"10.0.36.39:41140","server-name":"","error":"tls: client didn't provide a certificate"}
since we can't supply mTLS certs in the probe configs, we could try to split the http server out with the etcd args:
--listen-client-http-urls=
dunno if we can simply take on the ":2378" port for starters and then see if we still need some form of mTLS along with it.
|
(just checking something for another ticket - don't be confused) /override ci/prow/e2e-aws-etcd-recovery |
|
@tjungblu: Overrode contexts on behalf of tjungblu: ci/prow/e2e-aws-etcd-recovery In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@jubittajohn: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
openshift-merge-robot
added
the
needs-rebase
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
let's shelve this until we have a solution for /close |
|
@tjungblu: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
No description provided.